Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc fix: explain and correct the local container creation #1082

Merged
merged 3 commits into from
Nov 15, 2023
Merged

Doc fix: explain and correct the local container creation #1082

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dfb44f9
Fix instructions on local docker container tests
commjoen Nov 15, 2023
5f38116
Fix instructions and extend them for minikube usage when developing
commjoen Nov 15, 2023
7ec1314
Merge branch 'master' into doc-fix
commjoen Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,8 +489,12 @@ If you have made some changes to the codebase or added a new challenge and would
1. Ensure you have bash installed and open.
2. Navigate to .github/scripts.
3. Run the docker-create script `bash docker-create.sh`.
- Note: Do you want to run this on your minikube? then first run `eval $(minikube docker-env)`.
4. Follow any instructions given, you made need to install/change packages.
5. Run the newly created container `docker run -p 8080:8080 jeroenwillemsen/wrongsecrets:local-test`
5. Run the newly created container:
- to running locally: `docker run -p 8080:8080 jeroenwillemsen/wrongsecrets:local-test-no-vault`
- to run it on your minikube: use the container `jeroenwillemsen/wrongsecrets:local-test-k8s-vault` in your deployment definition.
- to run it with Vault on your minikube: use the container `jeroenwillemsen/wrongsecrets:local-test-local-vault` in your deployment definition.

## Want to play, but are not allowed to install the tools?

Expand Down
Loading