-
-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wxGUI/main_window: fix switches Map Display frame to full screen mode by keyboard shortcut #2480
Open
tmszi
wants to merge
5
commits into
OSGeo:main
Choose a base branch
from
tmszi:fix_wxgui_single_win_mode_map_disp_full_screen
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
wxGUI/main_window: fix switches Map Display frame to full screen mode by keyboard shortcut #2480
tmszi
wants to merge
5
commits into
OSGeo:main
from
tmszi:fix_wxgui_single_win_mode_map_disp_full_screen
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmszi
force-pushed
the
fix_wxgui_single_win_mode_map_disp_full_screen
branch
from
December 19, 2023 09:14
72a867e
to
d0d0653
Compare
echoix
force-pushed
the
fix_wxgui_single_win_mode_map_disp_full_screen
branch
from
March 31, 2024 02:16
d51c0c3
to
f5fb99b
Compare
… by keyboard shortcut Hides toolbars, statusbar and panes with keyboard shortcut F11 in single window mode.
echoix
force-pushed
the
fix_wxgui_single_win_mode_map_disp_full_screen
branch
from
April 24, 2024 02:06
f5fb99b
to
e2f572f
Compare
petrasovaa
requested changes
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be updated after #3003
"""Switches Map Display frame to full-screen mode, hides toolbars, | ||
statusbar and panes | ||
""" | ||
mapdisplay = self.mapnotebook.GetCurrentPage() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the mapnotebook got renamed.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the bug
Switches Map Display frame to full screen mode by keyboard shortcut F11 in single window mode is not working same as in multiple windows mode.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Switches Map Display frame to full screen mode by keyboard shortcut F11 should be working in single window mode same as in multiple windows mode.
Screenshots
Expected behavior:
System description (please complete the following information):