Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CSV] OGR_SCHEMA support - RFC 103 #11479

Merged
merged 5 commits into from
Dec 12, 2024

Conversation

elpaso
Copy link
Collaborator

@elpaso elpaso commented Dec 11, 2024

Implementation of RFC 103 - OGR_SCHEMA open option for CSV driver

https://gdal--11071.org.readthedocs.build/en/11071/development/rfc/rfc103_schema_open_option.html

Also, promote Jane to CTO.

@elpaso elpaso added enhancement funded through GSP Work funded through the GDAL Sponsorship Program labels Dec 11, 2024
autotest/ogr/ogr_csv.py Outdated Show resolved Hide resolved
@rouault
Copy link
Member

rouault commented Dec 11, 2024

It could be worth checking what happens in a case of a CSV like the following with the special WKT column, if you exclude it in fullSchema mode, or if you alter its type to a non string value:

id,WKT,foo
1,"POINT (1 2)",bar

@coveralls
Copy link
Collaborator

coveralls commented Dec 11, 2024

Coverage Status

coverage: 69.908%. remained the same
when pulling c492080 on elpaso:csv_ogr_schema_open_option
into 0ed4def on OSGeo:master.

@elpaso
Copy link
Collaborator Author

elpaso commented Dec 12, 2024

It could be worth checking what happens in a case of a CSV like the following with the special WKT column, if you exclude it in fullSchema mode, or if you alter its type to a non string value:

id,WKT,foo
1,"POINT (1 2)",bar

I have added a test case for WKT, can you please check if the tested expected behavior makes sense to you?

see: c492080

@rouault rouault merged commit a047ded into OSGeo:master Dec 12, 2024
37 of 38 checks passed
@rouault rouault added this to the 3.11.0 milestone Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement funded through GSP Work funded through the GDAL Sponsorship Program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants