Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDALTermProgress(): implement OSC 9;4 progress reporting protocol as … #11461

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

rouault
Copy link
Member

@rouault rouault commented Dec 8, 2024

…supported by ConEmu, recent PowerShell and other terminals

Fixes #11460

@rouault rouault added this to the 3.11.0 milestone Dec 8, 2024
@nyalldawson
Copy link
Collaborator

Wow, that was fast! 🤩

Copy link
Collaborator

@nyalldawson nyalldawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@rouault rouault marked this pull request as draft December 8, 2024 20:37
…supported by ConEmu, recent PowerShell and other terminals

On Windows, only use it if ConEmu or Windows Terminal specific
environment variables are detected.

Fixes OSGeo#11460
@rouault
Copy link
Member Author

rouault commented Dec 8, 2024

I gave this a try in my Windows 10 VM, and that works fine with ConEmu and PowerShell, but for the latest only if using the version of "Windows Terminal". Using regular cmd.exe or PowerShell 7.4.6 sandalone causes escape characters appear, and generate beep sounds... I've tuned the PR to check for the presence of ConEmu and Windows Terminal env variables to activate that on Windows.

@rouault rouault marked this pull request as ready for review December 8, 2024 20:55
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 68.58% (+0.002%) from 68.578%
when pulling 3dc1e30 on rouault:fix_11460
into f1911cf on OSGeo:master.

@rouault rouault merged commit d511807 into OSGeo:master Dec 9, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider supporting terminal progress commands (OSC9)
3 participants