Merge pull request #11316 from rouault/w_string_conversion

cmake/helpers/GdalCompilationFlags.cmake: enable -Wstring-conversion
OSGeo · Nov 20, 2024 · 5a7aac3 · 5a7aac3
2 parents 50585ef + 22363b7
commit 5a7aac3
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/cmake/helpers/GdalCompilationFlags.cmake b/cmake/helpers/GdalCompilationFlags.cmake
@@ -118,6 +118,8 @@ else ()
   detect_and_set_cxx_warning_flag(non-virtual-dtor)
   detect_and_set_cxx_warning_flag(overloaded-virtual)
   detect_and_set_cxx_warning_flag(suggest-override)
+  # clang specific only. Avoids that foo("bar") goes to foo(bool) instead of foo(const std::string&)
+  detect_and_set_cxx_warning_flag(string-conversion)
 
   check_cxx_compiler_flag(-fno-operator-names HAVE_FLAG_NO_OPERATOR_NAMES)
   if (HAVE_FLAG_NO_OPERATOR_NAMES)