Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial implementation of #150 #151

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

superwhiskers
Copy link
Collaborator

this pull request implements the initial suggestions proposed within #150

i'm not going to merge this until some discussion about the formatting options in .clang-format has happened, and appropriate modifications have been made to CONTRIBUTING.md

- drop dead code within `CMakeLists.txt`
- remove old `.github/workflows/.clang-format`
- create new `.clang-format` at the repository root, with settings based on observed patterns & `CONTRIBUTING.md`
@superwhiskers superwhiskers requested a review from pelesh June 3, 2024 21:36
@superwhiskers superwhiskers added documentation Improvements or additions to documentation enhancement New feature or request question Further information is requested labels Jun 3, 2024
@superwhiskers superwhiskers self-assigned this Jun 3, 2024
@pelesh pelesh requested a review from cameronrutherford June 5, 2024 13:58
Copy link
Collaborator

@cameronrutherford cameronrutherford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments, but I approve.

I am not a regex expert so I did not have a chance to verify that those are correct.

.clang-format Show resolved Hide resolved
.clang-format Show resolved Hide resolved
.clang-format Outdated Show resolved Hide resolved
.clang-format Show resolved Hide resolved
@pelesh
Copy link
Collaborator

pelesh commented Jun 11, 2024

Before it is ready for merge, we need to test it on a few representative code snippets to make sure there are no unintended artifacts.

.clang-format Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants