Merge pull request #96 from OHDSI/match_null

support null in matchedDiagnostics
OHDSI · Oct 30, 2024 · e55c0b9 · e55c0b9
2 parents a5ffb92 + cebac37
commit e55c0b9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/R/matchedDiagnostics.R b/R/matchedDiagnostics.R
@@ -54,7 +54,7 @@
 matchedDiagnostics <- function(cohort,
                                matchedSample = 1000){
 
-  omopgenerics::assertNumeric(matchedSample, min = 1)
+  omopgenerics::assertNumeric(matchedSample, min = 1, null = TRUE)
 
   cdm <- omopgenerics::cdmReference(cohort)
   cohortName <- omopgenerics::tableName(cohort)
@@ -72,7 +72,8 @@ matchedDiagnostics <- function(cohort,
                                    n = matchedSample,
                                    name = matchedCohortTable)
   } else {
-    cdm[[matchedCohortTable]] <- cdm[[cohortName]]
+    cdm[[matchedCohortTable]] <- cdm[[cohortName]] |>
+      dplyr::compute(name = matchedCohortTable, temporary = FALSE)
   }
 
   cli::cli_bullets(c("*" = "{.strong Generating a age and sex matched cohorts}"))

diff --git a/tests/testthat/test-matchedDiagnostics.R b/tests/testthat/test-matchedDiagnostics.R
@@ -28,6 +28,9 @@ test_that("cohort to pop diagnostics", {
                                  schema ="main", overwrite = TRUE)
   expect_no_error(result <- cdm$my_cohort |>
                     matchedDiagnostics())
+  # can be NULL and would do no sampling
+  cdm$my_cohort |>
+    matchedDiagnostics(matchedSample  = NULL)
 
   # expected errors
   expect_error(matchedDiagnostics(cohort = "not a cohort"))