Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent upload of inclusion rule names #156

Merged
merged 5 commits into from
Jun 5, 2024
Merged

Conversation

anthonysena
Copy link
Collaborator

Adds a cohortDefinitionSet parameter to exportCohortStatsTables which, when specified, will extract the inclusion rules from the cohort definition set and use those vs. attempting to export from the database. When the cohortDefinitionSet is NULL, a warning is now emitted to warn the user that if they have not inserted the inclusion rules into the DB, they may be missing (a common error I've made myself).

Also exports the getCohortInclusionRules function so that a user can extract the inclusion rules for a given cohort set as this useful.

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.55%. Comparing base (4ce1ae0) to head (7f11c01).
Report is 35 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #156      +/-   ##
===========================================
- Coverage    98.80%   97.55%   -1.26%     
===========================================
  Files           12       13       +1     
  Lines         1336     1593     +257     
===========================================
+ Hits          1320     1554     +234     
- Misses          16       39      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anthonysena anthonysena merged commit cdc6e24 into develop Jun 5, 2024
15 of 16 checks passed
@anthonysena anthonysena deleted the inclusion-rules branch June 5, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent upload of inclusion rule information
1 participant