[17.0][MIG] stock_orderpoint_generator #18

astirpe · 2024-05-24T09:53:37Z

No description provided.

And improve the wording * Add an option to automatically generate rules When a product variant is created with a (or several) rule template(s), it automatically generates (on the fly) the corresponding rule(s). When a rule template is modified, it automatically updates the existing rules of the linked products (it uses the mechanism in place, disable the old and create a fresh one). The latter update is done by a cron because it might take a long time to update all the products reordering rules. * Add documentation * Copy orderpoint views to orderpoint templates Unfortunately we cannot rely on the possibility to copy a view with "inherit_id" + "mode=primary" in Odoo 9.0 in this use case (precisely with a model that is a "copy by prototype"). The explanation: We "copy by prototype" the model "stock.warehouse.orderpoint" to a new "stock.warehouse.orderpoint.template" model (with both _inherit and different _name). Before this commit, we were reusing the stock.warehouse.orderpoint's views, just making the changes needed for the templates. Thing is: when a third (unrelated) addon adds a column on the model, the ORM doesn't add the column in the stock.warehouse.orderpoint.template model. So the templates' views complains about this unexisting field. Therefore, copy-pasting the view ensure that changes on 'stock.warehouse.orderpoint' does not have any side effect on the templates. From Odoo 10.0, the "copy by prototype" reports the changes made on the "prototype" model to the "copy" so we should be able to revert to the "inherit_id" + "mode=primary" views.

…h call create (#466)

Currently translated at 50.7% (38 of 75 strings) Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-stock_orderpoint_generator Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_orderpoint_generator/sl/

With initial wrong values we can carry a computing error to the subsequent moves.

A new option for auto computing minimum and maximum values depending on the actual delivered items for a period of time

TT36996

Currently translated at 23.6% (18 of 76 strings) Translation: stock-logistics-warehouse-15.0/stock-logistics-warehouse-15.0-stock_orderpoint_generator Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-15-0/stock-logistics-warehouse-15-0-stock_orderpoint_generator/it/

TT41548

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-warehouse-15.0/stock-logistics-warehouse-15.0-stock_orderpoint_generator Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-15-0/stock-logistics-warehouse-15-0-stock_orderpoint_generator/

The Size attribute is already defined in the point_of_sale module so when both modules are installed an error occurs in the tests. This is solved by changing the name of the attribute in the tests of the stock_orderpoint_generator module. TT41548

Currently translated at 20.0% (18 of 90 strings) Translation: stock-logistics-warehouse-15.0/stock-logistics-warehouse-15.0-stock_orderpoint_generator Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-15-0/stock-logistics-warehouse-15-0-stock_orderpoint_generator/it/

Currently translated at 100.0% (90 of 90 strings) Translation: stock-logistics-warehouse-15.0/stock-logistics-warehouse-15.0-stock_orderpoint_generator Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-15-0/stock-logistics-warehouse-15-0-stock_orderpoint_generator/es/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-warehouse-15.0/stock-logistics-warehouse-15.0-stock_orderpoint_generator Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-15-0/stock-logistics-warehouse-15-0-stock_orderpoint_generator/

astirpe · 2024-05-24T09:56:46Z

@rousseldenis
moved here!

gurneyalex · 2024-07-08T13:18:04Z

stock_orderpoint_generator/models/product.py

+    @api.model_create_multi
+    def create(self, vals_list):
+        products = super().create(vals_list)
+        for product in products.filtered(lambda pp: pp.auto_orderpoint_template_ids):


Suggested change

for product in products.filtered(lambda pp: pp.auto_orderpoint_template_ids):

for product in products.filtered("auto_orderpoint_template_ids"):

github-actions · 2024-11-10T12:30:23Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

rousseldenis · 2024-11-12T07:53:16Z

/ocabot migration stock_orderpoint_generator

rousseldenis

Little change

rousseldenis · 2024-11-12T07:55:03Z

stock_orderpoint_generator/models/orderpoint_template.py

+                ("company_id", "=", False),
+                ("company_id", "=", template.company_id.id),
+            ]
+            template.allowed_warehouse_ids = self.env["stock.warehouse"].search(domain)


Better to do the search outside the loop and then grouping templates per company and filter.

PicchiSeba · 2024-11-26T08:07:09Z

Hello @astirpe , I started working on the migration to 16.0 of this same module #27. Would you mind isolating the changes made to add the allowed_warehouse_ids/allowed_location_ids fields in a separate commit? This way I can cherry-pick it in my PR and preserve your authorship.

PicchiSeba

Code review:

We should squash administrative commits.

The commits def4859 and 9f3d791 should be squashed into f4e3ff0

Cyril Gaudin and others added 30 commits May 24, 2024 11:49

stock_orderpoint_generator: Migration V9

63bb8b6

[FIX] stock_orderpoint_generator (fields don't exist)

f7f7c5e

[FIX] stock_orderpoint_generator: fix a bug when iterate the data wit…

a131db5

…h call create (#466)

[MIG] stock_orderpoint_generator: Migration to 11.0

c75aaf3

[FIX] Fix singleton

51faebf

[IMP] stock_orderpoint_generator: auto values

129ce08

[MIG] stock_orderpoint_generator: Migration to 12.0

8778bd3

[IMP] stock_orderpoint_generator: black, isort, prettier

aa17593

[MIG] stock_orderpoint_generator: Migration to 13.0

2b413d1

[FIX] stock_orderpoint_generator: stock history initial value

8b8ea4e

With initial wrong values we can carry a computing error to the subsequent moves.

[IMP] stock_orderpoint_generator: delivered items options

9e3ee5e

A new option for auto computing minimum and maximum values depending on the actual delivered items for a period of time

[IMP] stock_orderpoint_generator: black, isort, prettier

5ebc979

[MIG] stock_orderpoint_generator: Migration to 15.0

ce8adf8

TT36996

[UPD] Update stock_orderpoint_generator.pot

ee01c4c

[UPD] README.rst

bf54c58

[FIX] stock_orderpoint_generator: disable computes

81a3e54

TT41548

[UPD] Update stock_orderpoint_generator.pot

d0334d7

stock_orderpoint_generator 15.0.1.0.1

b8c6b0e

stock_orderpoint_generator 15.0.1.0.2

a45f7d9

[UPD] README.rst

510b51c

astirpe added 2 commits May 24, 2024 11:50

[MIG] stock_orderpoint_generator: pre-commit

c1b7498

[MIG] stock_orderpoint_generator: migrate to V17

63e6482

astirpe marked this pull request as ready for review May 24, 2024 09:56

gurneyalex approved these changes Jul 8, 2024

View reviewed changes

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 10, 2024

OCA-git-bot added this to the 17.0 milestone Nov 12, 2024

OCA-git-bot mentioned this pull request Nov 12, 2024

Migration to version 17.0 #6

Open

3 tasks

rousseldenis added needs review migration labels Nov 12, 2024

rousseldenis requested changes Nov 12, 2024

View reviewed changes

github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 17, 2024

PicchiSeba suggested changes Nov 26, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0][MIG] stock_orderpoint_generator #18

[17.0][MIG] stock_orderpoint_generator #18

astirpe commented May 24, 2024

astirpe commented May 24, 2024

gurneyalex Jul 8, 2024

github-actions bot commented Nov 10, 2024

rousseldenis commented Nov 12, 2024

rousseldenis left a comment

rousseldenis Nov 12, 2024

PicchiSeba commented Nov 26, 2024

PicchiSeba left a comment

	for product in products.filtered(lambda pp: pp.auto_orderpoint_template_ids):
	for product in products.filtered("auto_orderpoint_template_ids"):

[17.0][MIG] stock_orderpoint_generator #18

Are you sure you want to change the base?

[17.0][MIG] stock_orderpoint_generator #18

Conversation

astirpe commented May 24, 2024

astirpe commented May 24, 2024

gurneyalex Jul 8, 2024

Choose a reason for hiding this comment

github-actions bot commented Nov 10, 2024

rousseldenis commented Nov 12, 2024

rousseldenis left a comment

Choose a reason for hiding this comment

rousseldenis Nov 12, 2024

Choose a reason for hiding this comment

PicchiSeba commented Nov 26, 2024

PicchiSeba left a comment

Choose a reason for hiding this comment