Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] stock_free_quantity: Migration to 17.0 #19

Merged
merged 20 commits into from
Nov 20, 2024

Conversation

jcadhoc
Copy link

@jcadhoc jcadhoc commented Apr 11, 2024

No description provided.

@jcadhoc jcadhoc force-pushed the 17.0-mig-stock_free_quantity branch from 3bd1764 to e02a5e7 Compare April 11, 2024 14:00
@rousseldenis rousseldenis changed the title 17.0 mig stock free quantity [17.0][MIG] stock_free_quantity Apr 25, 2024
@rousseldenis
Copy link
Contributor

/ocabot migration stock_free_quantity

Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Apr 25, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Apr 25, 2024
6 tasks
@jcadhoc
Copy link
Author

jcadhoc commented Jul 8, 2024

@rousseldenis Thank you for review! Can you merge? Or there is something pending?

@jcadhoc
Copy link
Author

jcadhoc commented Jul 23, 2024

@rousseldenis Hi Denis, do yo know why runboat is pending?

@rousseldenis
Copy link
Contributor

@rousseldenis Hi Denis, do yo know why runboat is pending?

I think this is because runboat was not on air when this was pushed. A rebase can solve it

@rousseldenis
Copy link
Contributor

@rousseldenis Thank you for review! Can you merge? Or there is something pending?

Usually, more than one review is required. Attract people here to review

@jcadhoc jcadhoc force-pushed the 17.0-mig-stock_free_quantity branch 2 times, most recently from 709a1e8 to 29433e9 Compare July 29, 2024 12:29
Copy link
Contributor

@florenciafrigieri2 florenciafrigieri2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review, working ok.

Copy link

@CasVissers-360ERP CasVissers-360ERP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review

@CasVissers-360ERP
Copy link

@rousseldenis Think it can be merged now (3 reviews including yours)

@rousseldenis
Copy link
Contributor

@jcadhoc Could you fix pre-commit ?

@jcadhoc
Copy link
Author

jcadhoc commented Oct 8, 2024

@rousseldenis Ready!

Sorry for the delay

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@jcadhoc jcadhoc changed the title [17.0][MIG] stock_free_quantity [17.0][MIG] stock_free_quantity: Migration to 17.0 Nov 15, 2024
@jcadhoc
Copy link
Author

jcadhoc commented Nov 15, 2024

@rousseldenis Hi Denis!

This pr is ok for merge?

I want to migrate it to 18 so better if we can merge this first

Copy link
Contributor

@florenciafrigieri2 florenciafrigieri2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test. Working ok. Free qty is ok within the product and in the product list.

@rousseldenis
Copy link
Contributor

@jcadhoc Could you squash your last pre-commit fix with the other one ? Thanks

@jcadhoc jcadhoc force-pushed the 17.0-mig-stock_free_quantity branch from 412c262 to 5c6aef1 Compare November 20, 2024 12:24
@jcadhoc jcadhoc force-pushed the 17.0-mig-stock_free_quantity branch from 5c6aef1 to 82a9e52 Compare November 20, 2024 12:26
@jcadhoc
Copy link
Author

jcadhoc commented Nov 20, 2024

@rousseldenis squashed!

Thank you.

@rousseldenis
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-19-by-rousseldenis-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit e6e0a41 into OCA:17.0 Nov 20, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b692075. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.