Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] session_db #3050

Merged
merged 32 commits into from
Nov 13, 2024
Merged

[18.0][MIG] session_db #3050

merged 32 commits into from
Nov 13, 2024

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Oct 7, 2024

No description provided.

nseinlet and others added 30 commits October 7, 2024 14:42
The upstream FilesystemSessionStore does not do that.
Retry on OperationalError exception, which we receive on database restart.
Return cursor to pool when reconnecting.
There were concurrency issues in evented mode.
So while I was at it, I added support for threaded mode too.
If the connection to the database fails when
retrying a session operation, we end up
with no cursore, which makes subsequent
session operations fail.

We fix this by ensuring we have cursor
before any operations.
…gument 'max_lifetime'" when autovacuum gets executed.

Signed-off-by: Christoph Fiehe <[email protected]>
It has been implemented.
@sbidoul sbidoul changed the title 18.0 mig session db sbi [18.0][MIG] session_db Oct 7, 2024
@sbidoul
Copy link
Member Author

sbidoul commented Oct 7, 2024

/ocabot migration session_db

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Oct 7, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 7, 2024
24 tasks
@sbidoul sbidoul force-pushed the 18.0-mig-session_db-sbi branch from 1afa279 to 84395fe Compare October 7, 2024 12:49
@sbidoul
Copy link
Member Author

sbidoul commented Oct 7, 2024

The CI failed on WARNING 👍, mute_logger to the rescue.

@sbidoul sbidoul force-pushed the 18.0-mig-session_db-sbi branch from 84395fe to 972358e Compare October 7, 2024 12:53
@sbidoul sbidoul requested a review from qgroulard October 7, 2024 12:57
@sbidoul
Copy link
Member Author

sbidoul commented Oct 7, 2024

Tested manually 👍

Copy link

@qgroulard qgroulard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (code review)

@sbidoul sbidoul force-pushed the 18.0-mig-session_db-sbi branch from 972358e to 7d2e3d8 Compare October 7, 2024 14:00
@sbidoul
Copy link
Member Author

sbidoul commented Oct 7, 2024

mute_logger to the rescue

or better, self.assertLogs

Copy link

@houssine78 houssine78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@sbidoul
Copy link
Member Author

sbidoul commented Nov 13, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-3050-by-sbidoul-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 94a6ea4 into OCA:18.0 Nov 13, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ae4bf65. Thanks a lot for contributing to OCA. ❤️

@sbidoul sbidoul deleted the 18.0-mig-session_db-sbi branch November 13, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants