-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] session_db #3050
[18.0][MIG] session_db #3050
Conversation
The upstream FilesystemSessionStore does not do that.
Retry on OperationalError exception, which we receive on database restart. Return cursor to pool when reconnecting.
There were concurrency issues in evented mode. So while I was at it, I added support for threaded mode too.
If the connection to the database fails when retrying a session operation, we end up with no cursore, which makes subsequent session operations fail. We fix this by ensuring we have cursor before any operations.
…gument 'max_lifetime'" when autovacuum gets executed. Signed-off-by: Christoph Fiehe <[email protected]>
It has been implemented.
/ocabot migration session_db |
1afa279
to
84395fe
Compare
The CI failed on WARNING 👍, |
84395fe
to
972358e
Compare
Tested manually 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (code review)
972358e
to
7d2e3d8
Compare
or better, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR has the |
/ocabot merge nobump |
On my way to merge this fine PR! |
Congratulations, your PR was merged at ae4bf65. Thanks a lot for contributing to OCA. ❤️ |
No description provided.