Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.0][MIG] sale_force_invoiced #3398

Merged
merged 66 commits into from
Dec 2, 2024
Merged

[18.0][MIG] sale_force_invoiced #3398

merged 66 commits into from
Dec 2, 2024

Conversation

odooexperts-visioncode
Copy link

No description provided.

JordiBForgeFlow and others added 30 commits November 11, 2024 16:14
@JordiBForgeFlow @odooexperts-visioncode
[9.0][ADD] module 'sale_force_invoiced' (OCA#439)
3a588f6 
* [ADD] module 'sale_force_invoiced' for 9.0

* [FIX] Travis
@oca-transbot @odooexperts-visioncode
OCA Transbot updated translations from Transifex
765d9b8
@MiquelRForgeFlow @odooexperts-visioncode
[MIG] sale_force_invoiced: Migration to 10.0
e617774
@oca-transbot @odooexperts-visioncode
OCA Transbot updated translations from Transifex
0bb7af6
@MiquelRForgeFlow @odooexperts-visioncode
[MIG] sale_force_invoiced: Migration to 11.0
6b7d9bc
@cubells @odooexperts-visioncode
[FIX] sale_force_invoiced: typo
5fbbcc2
@oca-transbot @odooexperts-visioncode
Update translation files
4b8ad8f 
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
@MiquelRForgeFlow @odooexperts-visioncode
[MIG] sale_force_invoiced: Migration to 12.0
e1e1497
@oca-transbot @odooexperts-visioncode
Update translation files
41091c1 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_force_invoiced
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_force_invoiced/
@marylla @odooexperts-visioncode
Translated using Weblate (German)
b064f0b 
Currently translated at 100.0% (3 of 3 strings)

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_force_invoiced
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_force_invoiced/de/
@liweijie0812 @odooexperts-visioncode
Translated using Weblate (Chinese (Simplified))
05b2971 
Currently translated at 100.0% (3 of 3 strings)

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_force_invoiced
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_force_invoiced/zh_CN/
@MiquelRForgeFlow @odooexperts-visioncode
[IMP] sale_force_invoiced: black, isort, prettier
83e8844
@MiquelRForgeFlow @odooexperts-visioncode
[MIG] sale_force_invoiced: Migration to 13.0
c8bd8f9
@oca-travis @odooexperts-visioncode
[UPD] Update sale_force_invoiced.pot
aeca134
@OCA-git-bot @odooexperts-visioncode
[UPD] README.rst
87efd95
@OCA-git-bot @odooexperts-visioncode
sale_force_invoiced 13.0.1.0.1
cf6f464
@oca-transbot @odooexperts-visioncode
Update translation files
e947082 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-13.0/sale-workflow-13.0-sale_force_invoiced
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_force_invoiced/
@danimv5 @odooexperts-visioncode
Translated using Weblate (Spanish)
3332efd 
Currently translated at 100.0% (3 of 3 strings)

Translation: sale-workflow-13.0/sale-workflow-13.0-sale_force_invoiced
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_force_invoiced/es/
@oca-transbot @odooexperts-visioncode
Update translation files
3651301 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-13.0/sale-workflow-13.0-sale_force_invoiced
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_force_invoiced/
@brendapaniagua @odooexperts-visioncode
Translated using Weblate (Catalan)
8609cf2 
Currently translated at 100.0% (3 of 3 strings)

Translation: sale-workflow-13.0/sale-workflow-13.0-sale_force_invoiced
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_force_invoiced/ca/
@LoisRForgeFlow @odooexperts-visioncode
[13.0][FIX] sale_force_invoiced: force the status always
26fbf0a 
Sometimes you have a SO that Odoo computes as "Nothing to invoice"
but you want to force it to "Fully invoiced" anyway.

Example: SO with 2 lines, line one is delivered and invoiced,
second line is never going to be delivered nor invoiced (
because of different bussiness reasons). In this situation you
still want to mark the SO as fully invoiced.
@OCA-git-bot @odooexperts-visioncode
sale_force_invoiced 13.0.1.1.0
0c9424f
@MateuGForgeFlow @odooexperts-visioncode
[MIG] sale_force_invoiced: Migration to 14.0
afb026d
@MateuGForgeFlow @odooexperts-visioncode
Allow force invoiced for sale and done states
cad5702
@oca-travis @odooexperts-visioncode
[UPD] Update sale_force_invoiced.pot
b2dfd7d
@OCA-git-bot @odooexperts-visioncode
[UPD] README.rst
686db39
@OCA-git-bot @odooexperts-visioncode
sale_force_invoiced 14.0.1.1.1
291a5f6
@Yvesldff @odooexperts-visioncode
Translated using Weblate (French)
0c467ff 
Currently translated at 100.0% (3 of 3 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_force_invoiced
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_force_invoiced/fr/
@JasminSForgeFlow @odooexperts-visioncode
[MIG] sale_force_invoiced: Migration to 15.0
adeac26
@JasminSForgeFlow @odooexperts-visioncode
[IMP] Update usage in README
26696ec
@rousseldenis
Copy link
Contributor

/ocabot migration sale_force_invoiced

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Nov 14, 2024
rousseldenis
rousseldenis reviewed Nov 14, 2024
View reviewed changes
sale_force_invoiced/__manifest__.py
@@ -4,7 +4,7 @@
{
"name": "Sale Force Invoiced",
"summary": "Allows to force the invoice status of the sales order to Invoiced",
"version": "17.0.1.1.1",
"version": "18.0.1.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change should be in migration commit

@rousseldenis
Copy link
Contributor

@odooexperts-visioncode Ok, I think you misunderstood what I wanted to say.

You should follow this :
https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0#technical-method-to-migrate-a-module-from-170-to-180-branch

The important part on the line with pre-commit stuff is the --no-verify option. Unless it will fail and ask you to change the version number. Pre-commit changes should stay in separate commit.

Then, you update the module version (and other changes maybe) and then you put them in the migration commit.

@odooexperts-visioncode
Copy link
Author

@rousseldenis Currently, there are not any changes in the pre-commit run, only pylint Failure for the version.

image

As there are not any change in the pre-commit, I might commit with --allow-empty

So, should I push an empty commit initially or the Direct Migration commit will be okay?

@rousseldenis
Copy link
Contributor

@rousseldenis Currently, there are not any changes in the pre-commit run, only pylint Failure for the version.

image

As there are not any change in the pre-commit, I might commit with --allow-empty

So, should I push an empty commit initially or the Direct Migration commit will be okay?

As I said, follow the procedure after running pre-commit run -a, do git commit -m "[IMP] $module: pre-commit auto fixes" --no-verify

image

@rousseldenis
Copy link
Contributor

As there are not any change in the pre-commit, I might commit with --allow-empty

Ooooh, ok. So, it's ok as is

@odooexperts-visioncode
Copy link
Author

odooexperts-visioncode commented Nov 14, 2024 •
edited
Loading

@rousseldenis So, do I push 2 commits (1 empty and 1 migration) or just a single migration commit is okay?

sheragar
sheragar approved these changes Nov 28, 2024
View reviewed changes
Copy link

@sheragar sheragar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Funtional Review 👍

StefanRijnhart
StefanRijnhart approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-3398-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 5c7b64b into OCA:18.0 Dec 2, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 0357871. Thanks a lot for contributing to OCA. ❤️

@ploegvde

This comment was marked as off-topic.

Sign in to view
@pedrobaeza

This comment was marked as off-topic.

Sign in to view
@ploegvde

This comment was marked as off-topic.

Sign in to view
@pedrobaeza

This comment was marked as off-topic.

Sign in to view
@ploegvde

This comment was marked as off-topic.

Sign in to view
@ploegvde

This comment was marked as off-topic.

Sign in to view
@pedrobaeza

This comment was marked as off-topic.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis left review comments

@sheragar sheragar sheragar approved these changes

@StefanRijnhart StefanRijnhart StefanRijnhart approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review
Projects
None yet
Milestone
18.0
Development

Successfully merging this pull request may close these issues.