Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] sale_product_set #3386

Open
wants to merge 77 commits into
base: 18.0
Choose a base branch
from

Conversation

sbejaoui
Copy link
Contributor

@sbejaoui sbejaoui commented Nov 4, 2024

No description provided.

Pierre Verkest and others added 30 commits November 4, 2024 16:22
* when a set is added to a sales order, it passes the unit of measure
of the product to the sales order line. Fixes an incompatibility with
module sale_margin.
…#543)

* [imp] move SO `add set` button to smartbutton header

* [fix] sale_product_set: PEP8
Currently translated at 100.0% (22 of 22 strings)

Translation: sale-workflow-11.0/sale-workflow-11.0-sale_product_set
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-11-0/sale-workflow-11-0-sale_product_set/es/
Currently translated at 100.0% (24 of 24 strings)

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_product_set
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_product_set/es/
Currently translated at 100.0% (25 of 25 strings)

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_product_set
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_product_set/de/
Currently translated at 100.0% (27 of 27 strings)

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_product_set
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_product_set/zh_CN/
Add `partner_id` to product.set allowing to define specific sets per customer
Before this change: try to delete a set used in a wizard right after
-> KABOOM! The FK over the set would prevent deletion
sysadminmatmoz and others added 16 commits November 4, 2024 16:22
Currently translated at 58.3% (21 of 36 strings)

Translation: sale-workflow-15.0/sale-workflow-15.0-sale_product_set
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_product_set/sl/
[UPD] Update sale_product_set.pot

[UPD] README.rst

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-16.0/sale-workflow-16.0-sale_product_set
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_product_set/

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-16.0/sale-workflow-16.0-sale_product_set
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_product_set/

Translated using Weblate (Spanish)

Currently translated at 100.0% (23 of 23 strings)

Translation: sale-workflow-16.0/sale-workflow-16.0-sale_product_set
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_product_set/es/

[UPD] README.rst
Translated using Weblate (Italian)

Currently translated at 100.0% (23 of 23 strings)

Translation: sale-workflow-16.0/sale-workflow-16.0-sale_product_set
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_product_set/it/

[UPD] Update sale_product_set.pot

[BOT] post-merge updates

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-16.0/sale-workflow-16.0-sale_product_set
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_product_set/

Translated using Weblate (Italian)

Currently translated at 100.0% (26 of 26 strings)

Translation: sale-workflow-16.0/sale-workflow-16.0-sale_product_set
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_product_set/it/

Translated using Weblate (Spanish)

Currently translated at 100.0% (26 of 26 strings)

Translation: sale-workflow-16.0/sale-workflow-16.0-sale_product_set
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_product_set/es/
… product_set

The reason to move this logic is that there are other modules that extend
product_set as for example stock_product_set but at the same time make use
of the transient model to define a wizard. For this reason it is better to
have the logic available in product_set module and avoid duplicating code or
inheriting from sale_product_set and what this implies in their respective
dependencies with the only need to extend the transient model.
In addition, the transient model is renamed to make it clearer to identify
that it is this type of model.

TT48100

[UPD] Update sale_product_set.pot

[BOT] post-merge updates

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-16.0/sale-workflow-16.0-sale_product_set
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_product_set/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-17.0/sale-workflow-17.0-sale_product_set
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_product_set/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-17.0/sale-workflow-17.0-sale_product_set
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_product_set/
Currently translated at 100.0% (25 of 25 strings)

Translation: sale-workflow-17.0/sale-workflow-17.0-sale_product_set
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_product_set/de/
Currently translated at 100.0% (25 of 25 strings)

Translation: sale-workflow-17.0/sale-workflow-17.0-sale_product_set
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_product_set/sv/
Currently translated at 100.0% (25 of 25 strings)

Translation: sale-workflow-17.0/sale-workflow-17.0-sale_product_set
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_product_set/it/
@natuan9
Copy link

natuan9 commented Dec 3, 2024

Hi @sbejaoui , There is PR in 14.0 that is not included. I create this PR to port it to 18.0

[MIG] sale_product_set: add migration to 18.0 for syncing product set state
@rousseldenis
Copy link
Contributor

/ocabot migration sale_product_set

Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sbejaoui Could you fix pre-commit ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.