Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][IMP] sale_order_line_sequence: attrs removed #3296

Merged
merged 1 commit into from
Sep 2, 2024
Merged

[17.0][IMP] sale_order_line_sequence: attrs removed #3296

merged 1 commit into from
Sep 2, 2024

Conversation

SodexisTeam
Copy link
Member

No description provided.

@StefanRijnhart StefanRijnhart mentioned this pull request Sep 2, 2024
Merged
DorianMAG
DorianMAG approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@DorianMAG DorianMAG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
Code review.
LGTM

You are correct, the attribute "attrs" no longer works since version 17. Thank you for the fix.

@StefanRijnhart
Copy link
Member

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-3296-by-StefanRijnhart-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit f9249e6 into OCA:17.0 Sep 2, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 76d7820. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorianMAG DorianMAG DorianMAG approved these changes

@StefanRijnhart StefanRijnhart StefanRijnhart approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SodexisTeam @StefanRijnhart @OCA-git-bot @DorianMAG @sakthi-shan