[17.0][MIG/IMP] sale_validity_auto_cancel: Migration to 17.0 #3204
Conversation
fd-oerp
force-pushed
the
17.0-sale_validity_auto_cancel
branch
from
b2d9a70 to
4738990
Compare
|
Could you please review this PR and let me know if anything needs to be updated from my end? Thank you |
|
/ocabot migration sale_validity_auto_cancel |
There was a problem hiding this comment.
Code review.
@fd-oerp Could you update this according to @JordiMForgeFlow comment ?
fd-oerp
force-pushed
the
17.0-sale_validity_auto_cancel
branch
from
4738990 to
fb9e0a6
Compare
… SO functionality by adding new field to contact [17.0][IMP] sale_validity_auto_cancel: Extend the auto cancel expired SO functionality by adding new field to contact [17.0][IMP] sale_validity_auto_cancel: Extend the auto cancel expired SO functionality by adding new field to contact
fd-oerp
force-pushed
the
17.0-sale_validity_auto_cancel
branch
from
403e276 to
7badc79
Compare
|
Hi @JordiMForgeFlow @rousseldenis I have updated the commits as you suggested, with one for MIG and one for IMP. Additionally, I have updated the field name to be suitable according to the module's technical name. I'm not sure why one check failed—it seems like it might be due to another module. Could you please guide me if I'm missing something related to the failed check? Please review and let me know if anything needs to be updated from my end. Thank you! |
|
Could you please review the changes I made as per @JordiMForgeFlow's suggestions and proceed with this PR accordingly? Let me know if anything needs to be updated from my end. Thank you |
|
Hi, Could this PR proceed further, or please let me know if anything needs to be updated on my end? Thank you |
|
Could this PR proceed further, or please let me know if anything needs to be updated on my end? Thank you |
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at df2c1a4. Thanks a lot for contributing to OCA. ❤️ |
This module has been migrated to V17.0, and a new functionality has been added.
Description:
The 'Keep SO' field is a boolean field added to the res.partner model.
This field is connected to the sale.order model using a related field.
Functionality/Use:
This feature provides a dynamic configuration that allows users to manage sales orders (SOs) based on the partner ID. If the 'Keep SO' field is checked, it prevents the automatic cancellation of sales orders associated with that partner.
With this functionality, clients can enforce specific restrictions. For instance, certain sales orders can be protected from being canceled if they are linked to partners for whom the 'Keep SO' field is enabled.
This will enhances operational efficiency by ensuring critical sales orders remain active and are not canceled inadvertently. This new feature aims to improve the management of sales orders, providing greater customization and control over the sales process.