[17.0][MIG] product_supplierinfo_for_customer_sale: Migration to 17.0 #3149

xmglord · 2024-05-24T01:29:16Z

No description provided.

xmglord · 2024-05-24T04:03:03Z

This is waiting for this to be merged.

[REF] product_supplierinfo_for_customer_sale: Changes in test. [REF] product_supplierinfo_for_customer_sale: Complete README.rst

…rch, products found by default code and customer code [REF] product_supplierinfo_for_customer_sale: Add test to find more than one product in name_search [REF] product_supplierinfo_for_customer_sale: In test find one product from customer code and other one from product default code. [REF] product_supplierinfo_for_customer_sale: Changes in name_search to work exactly with number of limit defined. [REF] product_supplierinfo_for_customer_sale: Changes in name_search

- New field name from type to supplierinfo_type - Remove copyright for __init__.py - Re-using variables from tests - Manifest bump version and using module url - Get commit history from https://github.com/OCA/product-attribute/tree/8.0/product_supplierinfo_for_customer_sale - Run 2to3 script - view fixing

… instead of manual assign. - Removing duplicated test for name_search

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

There's no price computation on the module, so there shouldn't be any test regarding this topic, or it can fail in integration tests.

types: int() >= NoneType()

Currently translated at 11.1% (1 of 9 strings) Translation: sale-workflow-11.0/sale-workflow-11.0-product_supplierinfo_for_customer_sale Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-11-0/sale-workflow-11-0-product_supplierinfo_for_customer_sale/de/

…fo by product variant first

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-12.0/sale-workflow-12.0-product_supplierinfo_for_customer_sale Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-product_supplierinfo_for_customer_sale/

Currently translated at 100.0% (6 of 6 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-product_supplierinfo_for_customer_sale Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-product_supplierinfo_for_customer_sale/pt/

xmglord · 2024-06-05T22:41:51Z

@pedrobaeza this is ready for merge.

pedrobaeza · 2024-06-06T07:04:05Z

/ocabot migration product_supplierinfo_for_customer_sale

Reviews are missing

xmglord · 2024-06-06T07:06:30Z

/ocabot migration product_supplierinfo_for_customer_sale

Reviews are missing

MB you're right. @luisg123v please review.

luisg123v · 2024-06-06T18:49:23Z

product_supplierinfo_for_customer_sale/README.rst

@@ -17,25 +17,26 @@ Product Supplierinfo for Customer Sale
    :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
    :alt: License: AGPL-3
 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fsale--workflow-lightgray.png?logo=github
-    :target: https://github.com/OCA/sale-workflow/tree/16.0/product_supplierinfo_for_customer_sale
+    :target: https://github.com/OCA/sale-workflow/tree/17.0/product_supplierinfo_for_customer_sale


Commit title:

execution → autofixes

luisg123v · 2024-06-06T18:52:57Z

product_supplierinfo_for_customer_sale/tests/test_product_name_search.py

@@ -11,7 +11,7 @@ class TestProductNameSearch(TransactionCase):
    """

    def setUp(self):
-        super(TestProductNameSearch, self).setUp()
+        super().setUp()


Isn't this part of the precommit changes? Did you perform this change manually?

Nop I had to apply it by myself, it is indeed a lint but the autofix didn't change it.

luisg123v · 2024-06-06T18:57:40Z

product_supplierinfo_for_customer_sale/tests/test_product_supplierinfo_for_customer_sale.py

+
+
+class TestProductSupplierinfoForCustomerSale(TransactionCase):
+    def setUp(self):


setUpClass

Same in the other test file.

luisg123v

LGTM 👍

Hi @moylop260 or @pedrobaeza,

Could you review/merge, please?

CC @desdelinux

OCA-git-bot · 2024-06-08T19:00:01Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

luisg123v · 2024-06-14T17:38:49Z

@moylop260 or @pedrobaeza,

Friendly reminder, this is approved and waiting for merge.

moylop260 · 2024-06-14T19:26:43Z

/ocabot merge nobump

OCA-git-bot · 2024-06-14T19:27:12Z

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-3149-by-moylop260-bump-nobump, awaiting test results.

OCA-git-bot · 2024-06-14T19:34:10Z

Congratulations, your PR was merged at 88d878a. Thanks a lot for contributing to OCA. ❤️

xmglord force-pushed the 17.0-mig_product_supplierinfo_for_customer_sale-xmglord branch from f382994 to 142e823 Compare May 24, 2024 01:33

xmglord force-pushed the 17.0-mig_product_supplierinfo_for_customer_sale-xmglord branch from 142e823 to d87324e Compare June 4, 2024 00:30

AaronHForgeFlow and others added 27 commits June 5, 2024 21:35

[UPT]rename module product_customer_code

57f6fe8

[FIX] Pass customer code and min qty to sale order line

802b2db

[ADD] Tests

a74272a

[UPD] Update product_supplierinfo_for_customer_sale.pot

18dd9e2

product_supplierinfo_for_customer_sale: New module.

25fa4cd

[REF] product_supplierinfo_for_customer_sale: Changes in test. [REF] product_supplierinfo_for_customer_sale: Complete README.rst

[REF] product_supplierinfo_for_customer_sale: Use product.name_search…

acab75f

… instead of manual assign. - Removing duplicated test for name_search

[REF] product_supplierinfo_for_customer_sale: Adding Vauxoo author

7dc278c

[UPD] README.rst

f7a0841

[UPD] Update product_supplierinfo_for_customer_sale.pot

dcdcf5b

[UPD] README.rst

7b48393

Update translation files

aa17610

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

[FIX] product_supplierinfo_for_customer_sale: Remove offending test

45fb94f

There's no price computation on the module, so there shouldn't be any test regarding this topic, or it can fail in integration tests.

[FIX] product_supplierinfo_for_customer_sale: TypeError: unorderable

04e27e1

types: int() >= NoneType()

Added translation using Weblate (German)

2da5405

[UPD] README.rst

e4ea03d

[11.0][FIX] product_supplierinfo_for_customer_sale: Search supplierin…

1d32883

…fo by product variant first

product_supplierinfo_for_customer_sale 11.0.1.0.1

9a6a70b

[12.0][MIG] product_supplierinfo_for_customer_sale

8229c87

[IMP] Split of 'product.supplierinfo' for 'product.customerinfo'

fa68358

[UPD] Update product_supplierinfo_for_customer_sale.pot

d33452f

[UPD] README.rst

8443fe7

Added translation using Weblate (Portuguese)

3a28a28

xmglord force-pushed the 17.0-mig_product_supplierinfo_for_customer_sale-xmglord branch 5 times, most recently from ab111a6 to 37cd08b Compare June 5, 2024 22:38

OCA-git-bot added this to the 17.0 milestone Jun 6, 2024

OCA-git-bot mentioned this pull request Jun 6, 2024

Migration to version 17.0 #2766

Open

83 tasks

desdelinux approved these changes Jun 6, 2024

View reviewed changes

luisg123v suggested changes Jun 6, 2024

View reviewed changes

[IMP] product_supplierinfo_for_customer_sale: pre-commit autofixes

dfb309a

xmglord force-pushed the 17.0-mig_product_supplierinfo_for_customer_sale-xmglord branch from 37cd08b to 80f8294 Compare June 7, 2024 01:35

xmglord requested a review from luisg123v June 7, 2024 01:35

xmglord force-pushed the 17.0-mig_product_supplierinfo_for_customer_sale-xmglord branch from 80f8294 to c759f20 Compare June 7, 2024 01:42

[MIG] product_supplierinfo_for_customer_sale: Migration to 17.0

a8f72de

xmglord force-pushed the 17.0-mig_product_supplierinfo_for_customer_sale-xmglord branch from c759f20 to a8f72de Compare June 7, 2024 01:55

luisg123v approved these changes Jun 8, 2024

View reviewed changes

OCA-git-bot added approved ready to merge labels Jun 8, 2024

OCA-git-bot added the bot is merging ⏳ label Jun 14, 2024

OCA-git-bot merged commit 48519fe into OCA:17.0 Jun 14, 2024
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jun 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0][MIG] product_supplierinfo_for_customer_sale: Migration to 17.0 #3149

[17.0][MIG] product_supplierinfo_for_customer_sale: Migration to 17.0 #3149

xmglord commented May 24, 2024

xmglord commented May 24, 2024

xmglord commented Jun 5, 2024

pedrobaeza commented Jun 6, 2024

xmglord commented Jun 6, 2024

luisg123v Jun 6, 2024

xmglord Jun 7, 2024

luisg123v Jun 6, 2024

xmglord Jun 7, 2024

luisg123v Jun 6, 2024

xmglord Jun 7, 2024

luisg123v left a comment

OCA-git-bot commented Jun 8, 2024

luisg123v commented Jun 14, 2024

moylop260 commented Jun 14, 2024

OCA-git-bot commented Jun 14, 2024

OCA-git-bot commented Jun 14, 2024



		class TestProductSupplierinfoForCustomerSale(TransactionCase):
		def setUp(self):

[17.0][MIG] product_supplierinfo_for_customer_sale: Migration to 17.0 #3149

[17.0][MIG] product_supplierinfo_for_customer_sale: Migration to 17.0 #3149

Conversation

xmglord commented May 24, 2024

xmglord commented May 24, 2024

xmglord commented Jun 5, 2024

pedrobaeza commented Jun 6, 2024

xmglord commented Jun 6, 2024

luisg123v Jun 6, 2024

Choose a reason for hiding this comment

xmglord Jun 7, 2024

Choose a reason for hiding this comment

luisg123v Jun 6, 2024

Choose a reason for hiding this comment

xmglord Jun 7, 2024

Choose a reason for hiding this comment

luisg123v Jun 6, 2024

Choose a reason for hiding this comment

xmglord Jun 7, 2024

Choose a reason for hiding this comment

luisg123v left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Jun 8, 2024

luisg123v commented Jun 14, 2024

moylop260 commented Jun 14, 2024

OCA-git-bot commented Jun 14, 2024

OCA-git-bot commented Jun 14, 2024