Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][IMP] product_supplierinfo_for_customer_sale: Add compatibility with Form() to change line name properly #3134

Merged
merged 1 commit into from
May 23, 2024
Merged

[15.0][IMP] product_supplierinfo_for_customer_sale: Add compatibility with Form() to change line name properly #3134

merged 1 commit into from
May 23, 2024

Conversation

victoralmau
Copy link
Member

Add compatibility with Form() to change line name properly

@Tecnativa TT49073

@victoralmau victoralmau force-pushed the 15.0-imp-product_supplierinfo_for_customer_sale-TT49073 branch from e5b3c40 to ab5f73d Compare May 13, 2024 15:53
@pedrobaeza pedrobaeza added this to the 15.0 milestone May 14, 2024
pedrobaeza
pedrobaeza reviewed May 14, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to search for pricelist items? I don't get that need. About your new approach, it's doing again the customerinfo selection, and also overriding any other custom behavior, so it doesn't feel OK. Why can't this be done at once using the same customerinfo and not overriding the text?

@victoralmau
Copy link
Member Author

Sorry, can you indicate exactly what change you want to do to solve the problem? The previous approach was incorrect and so is this one. The current implementation of all the code may look strange, although all the logic is in product_supplierinfo_for_customer.

@pedrobaeza pedrobaeza force-pushed the 15.0-imp-product_supplierinfo_for_customer_sale-TT49073 branch 5 times, most recently from 63f218a to 127f78a Compare May 15, 2024 09:56
@pedrobaeza pedrobaeza requested a review from LoisRForgeFlow May 15, 2024 10:08
@pedrobaeza
Copy link
Member

@victoralmau changed approach to be friendlier with other extensions.

@pedrobaeza pedrobaeza force-pushed the 15.0-imp-product_supplierinfo_for_customer_sale-TT49073 branch from 127f78a to c8927a5 Compare May 23, 2024 14:35
@victoralmau @pedrobaeza
[IMP] product_supplierinfo_for_customer_sale: Add compatibility with …
48ebb0c 
…Form() to change line name properly

TT49073

Co-Authored-By: Pedro M. Baeza <[email protected]>
@pedrobaeza pedrobaeza force-pushed the 15.0-imp-product_supplierinfo_for_customer_sale-TT49073 branch from c8927a5 to 48ebb0c Compare May 23, 2024 14:39
@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-3134-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 3eca12f into OCA:15.0 May 23, 2024
11 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ac31770. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 15.0-imp-product_supplierinfo_for_customer_sale-TT49073 branch May 23, 2024 17:11
This was referenced May 25, 2024
Merged
Merged
@victoralmau victoralmau mentioned this pull request May 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@LoisRForgeFlow LoisRForgeFlow Awaiting requested review from LoisRForgeFlow

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@victoralmau @pedrobaeza @OCA-git-bot