Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] sale_order_carrier_auto_assign: Migration to 17.0 #3104

Merged

Conversation

lef-adhoc
Copy link

No description provided.

@lef-adhoc lef-adhoc force-pushed the 17.0-mig-sale_order_carrier_auto_assign branch 3 times, most recently from a398eac to 4cb8e90 Compare April 26, 2024 16:19
@lef-adhoc lef-adhoc mentioned this pull request Apr 26, 2024
83 tasks
@lef-adhoc lef-adhoc force-pushed the 17.0-mig-sale_order_carrier_auto_assign branch 2 times, most recently from 27ba25c to a8345ef Compare April 30, 2024 12:58
@rousseldenis
Copy link
Contributor

/ocabot migration sale_order_carrier_auto_assign

@lef-adhoc Could you rebase ?

@lef-adhoc lef-adhoc force-pushed the 17.0-mig-sale_order_carrier_auto_assign branch from a8345ef to 83a456f Compare May 8, 2024 14:14
@lef-adhoc
Copy link
Author

@rousseldenis the rebase is ready

Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

Copy link
Member

@FrancoMaxime FrancoMaxime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: code review

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@@ -32,7 +33,9 @@ def test_sale_order_carrier_auto_assign(self):
self.sale_order.action_confirm()
self.assertEqual(self.sale_order.state, "sale")
self.assertEqual(self.sale_order.carrier_id, self.delivery_local_delivery)
delivery_line = self.sale_order.order_line.filtered(lambda l: l.is_delivery)
delivery_line = self.sale_order.order_line.filtered(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, self.sale_order.order_line.filtered("is_delivery") is working well.

@rousseldenis
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-3104-by-rousseldenis-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 180b514 into OCA:17.0 Jun 24, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 597f587. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.