-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] sale_order_carrier_auto_assign: Migration to 17.0 #3104
[17.0][MIG] sale_order_carrier_auto_assign: Migration to 17.0 #3104
Conversation
a398eac
to
4cb8e90
Compare
27ba25c
to
a8345ef
Compare
/ocabot migration sale_order_carrier_auto_assign @lef-adhoc Could you rebase ? |
Currently translated at 100.0% (1 of 1 strings) Translation: sale-workflow-13.0/sale-workflow-13.0-sale_order_carrier_auto_assign Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_order_carrier_auto_assign/es/
Currently translated at 100.0% (1 of 1 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_carrier_auto_assign Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_carrier_auto_assign/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_carrier_auto_assign Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_carrier_auto_assign/
Currently translated at 100.0% (7 of 7 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_carrier_auto_assign Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_carrier_auto_assign/it/
a8345ef
to
83a456f
Compare
@rousseldenis the rebase is ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM: code review
This PR has the |
@@ -32,7 +33,9 @@ def test_sale_order_carrier_auto_assign(self): | |||
self.sale_order.action_confirm() | |||
self.assertEqual(self.sale_order.state, "sale") | |||
self.assertEqual(self.sale_order.carrier_id, self.delivery_local_delivery) | |||
delivery_line = self.sale_order.order_line.filtered(lambda l: l.is_delivery) | |||
delivery_line = self.sale_order.order_line.filtered( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, self.sale_order.order_line.filtered("is_delivery")
is working well.
/ocabot merge nobump |
On my way to merge this fine PR! |
Congratulations, your PR was merged at 597f587. Thanks a lot for contributing to OCA. ❤️ |
No description provided.