Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] sale_order_line_menu: Migration to 17.0 #3049

Merged
merged 16 commits into from
Apr 4, 2024
Merged

[17.0][MIG] sale_order_line_menu: Migration to 17.0 #3049

merged 16 commits into from
Apr 4, 2024

Conversation

MohamedOsman7
Copy link

No description provided.

@MohamedOsman7 MohamedOsman7 mentioned this pull request Mar 28, 2024
Open
83 tasks
Freni-OSI and others added 15 commits March 28, 2024 10:18
@Freni-OSI
[14.0][ADD]Added Module sale_order_line_menu
79510b2
@Yvesldff
Added translation using Weblate (French (France)), (Spanish), (Franch…
d8af451 
… (Belgium))

Translated using Weblate (French (France))

Currently translated at 100.0% (1 of 1 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_order_line_menu
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_order_line_menu/fr_FR/

Added translation using Weblate (Spanish)

Translated using Weblate (Spanish)

Currently translated at 100.0% (1 of 1 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_order_line_menu
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_order_line_menu/es/

Added translation using Weblate (French (Belgium))

Added translation using Weblate (French)

Translated using Weblate (French)

Currently translated at 100.0% (1 of 1 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_order_line_menu
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_order_line_menu/fr/
@RLeeOSI
[MIG] sale_order_line_menu: Migration to 15.0
cb63313
@Murtaza-OSI
[16.0][MIG] sale_order_line_menu
93d07de
@badbole
Added translation using Weblate (Croatian)
335a8f7
@dalonsofl
[16.0][IMP]sale_order_line_menu: set no visible sections and notes in…
fa13fcf 
… sale order lines menu
@dalonsofl
[16.0][IMP]sale_order_line_menu: set no visible sale order line menu …
5ba44f8 
…if you do not have any Sales permission
@EmilioPascual
[16.0][IMP] sale_order_line_menu: New views and stored fields
fb9285a 
New views and fields added to the sale_order_line_menu

MT-2028 @moduon @rafaelbn @dreispt @Shide @fcvalgar please review
@weblate
Update translation files
cbe81b6 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_line_menu
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_line_menu/
@Ivorra78
Translated using Weblate (Spanish)
b5fcfe4 
Currently translated at 100.0% (19 of 19 strings)

Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_line_menu
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_line_menu/es/
@sbidoul
Convert sale_order_line_menu readme fragments to markdown
dfdd288
@adrianojprado
Added translation using Weblate (Portuguese (Brazil))
26a6671
@jappi00
Added translation using Weblate (German)
72c163b
@mymage
Added translation using Weblate (Italian)
d7f2dbb
[IMP] sale_order_line_menu: black, isort, prettier
f7c111c
@MohamedOsman7 MohamedOsman7 force-pushed the 17.0-mig-sale_order_line_menu branch from bd59b43 to f7c111c Compare March 28, 2024 10:19
CRogos
CRogos suggested changes Mar 28, 2024
View reviewed changes
sale_order_line_menu/models/sale_order_line.py Outdated
Comment on lines 15 to 20
account_analytic_id = fields.Many2one(
related="order_id.analytic_account_id",
readonly=True,
store=True,
index=True,
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should fix the typo and rename field the same as in sale.order:
account_analytic_id -> analytic_account_id

of cause this needs also to be updated in the views.

@MohamedOsman7 MohamedOsman7 force-pushed the 17.0-mig-sale_order_line_menu branch from 67f85c1 to 202a89d Compare March 28, 2024 15:59
@MohamedOsman7 MohamedOsman7 force-pushed the 17.0-mig-sale_order_line_menu branch from 202a89d to ba56eb7 Compare March 28, 2024 16:16
@celm1990
Copy link
Contributor

Please split commits according guideslines
https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0#technical-method-to-migrate-a-module-from-160-to-170-branch
image

@rafaelbn rafaelbn added this to the 17.0 milestone Apr 1, 2024
@rafaelbn
Copy link
Member

rafaelbn commented Apr 1, 2024

/ocabot migration sale_order_line_menu

@moduon @EmilioPascual

@CRogos
Copy link
Contributor

CRogos commented Apr 2, 2024

@celm1990 I think you are looking for these two commits.

I agree that the naming is not 100%, this is because we are using oca-port which generates the first commit automatically and the commit message is still from migration 14->15.

image

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@EmilioPascual
Copy link
Contributor

/ocabot merge

@OCA-git-bot
Copy link
Contributor

Hi @EmilioPascual. Your command failed:

Required option bumpversion_mode for command merge. Possible values : major, minor, patch, nobump.

Ocabot commands

  • ocabot merge major|minor|patch|nobump
  • ocabot rebase
  • ocabot migration {MODULE_NAME}

More information

@CRogos
Copy link
Contributor

CRogos commented Apr 4, 2024

@EmilioPascual could you retry with "nobump" at the end?

@EmilioPascual
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Sorry @EmilioPascual you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

rafaelbn
rafaelbn approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-3049-by-rafaelbn-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit fce54eb into OCA:17.0 Apr 4, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 21e834e. Thanks a lot for contributing to OCA. ❤️

@CRogos CRogos deleted the 17.0-mig-sale_order_line_menu branch April 5, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmilioPascual EmilioPascual EmilioPascual approved these changes

@rafaelbn rafaelbn rafaelbn approved these changes

@angelmoya angelmoya angelmoya approved these changes

@CRogos CRogos CRogos approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 needs review ready to merge
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.