Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] sale_delivery_state #3013

Merged
merged 32 commits into from
Apr 3, 2024

Conversation

astirpe
Copy link
Member

@astirpe astirpe commented Mar 14, 2024

No description provided.

@astirpe astirpe marked this pull request as ready for review March 14, 2024 06:03
@astirpe astirpe mentioned this pull request Mar 14, 2024
83 tasks
Copy link

@CasVissers-360ERP CasVissers-360ERP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review

@astirpe astirpe marked this pull request as draft March 14, 2024 06:22
@astirpe astirpe force-pushed the 17_mig_sale_delivery_state branch 2 times, most recently from 70632c2 to 4376121 Compare March 14, 2024 07:35
@astirpe astirpe marked this pull request as ready for review March 14, 2024 07:38
Copy link
Contributor

@celm1990 celm1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
could you squash administrative commits, please

@astirpe astirpe force-pushed the 17_mig_sale_delivery_state branch from 4376121 to b652d45 Compare March 16, 2024 08:00
@astirpe
Copy link
Member Author

astirpe commented Mar 16, 2024

@celm1990 squashed

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@etobella
Copy link
Member

etobella commented Apr 3, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-3013-by-etobella-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 7177926 into OCA:17.0 Apr 3, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 9d4e252. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.