Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] sale_exception: Migration to 17.0 #2860

Merged
merged 76 commits into from
Apr 28, 2024
Merged

[17.0][MIG] sale_exception: Migration to 17.0 #2860

merged 76 commits into from
Apr 28, 2024

Conversation

nguyenminhchien
Copy link
Contributor

@nguyenminhchien nguyenminhchien commented Dec 18, 2023 •
edited
Loading

No description provided.

@nguyenminhchien nguyenminhchien marked this pull request as ready for review December 18, 2023 11:05
@gurneyalex
Copy link
Member

/ocabot migration sale_exception

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Dec 20, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Dec 20, 2023
Open
83 tasks
john-herholz-dt
john-herholz-dt approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@john-herholz-dt john-herholz-dt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@lef-adhoc lef-adhoc mentioned this pull request Jan 18, 2024
Closed
2 tasks
@gurneyalex
Copy link
Member

@nguyenminhchien OCA/server-tools#2809 was merged for base_exception, can you remove the other PR from test-requirements.txt?

@nguyenminhchien nguyenminhchien force-pushed the 17.0-mig-sale_exception branch from 6a2b4bb to 83700ca Compare February 2, 2024 08:31
@nguyenminhchien
Copy link
Contributor Author

@nguyenminhchien OCA/server-tools#2809 was merged for base_exception, can you remove the other PR from test-requirements.txt?

Hi, i removed that file. but the pre-commit check was failed because of ****po-pretty-format****, it will take a lot of time to fix
image

@nguyenminhchien
Copy link
Contributor Author

Hi, i removed that file. but the pre-commit check was failed because of ****po-pretty-format****, it will take a lot of time to fix !

omg, the pre-commit check failed not because of this module but others such as sale_order_type, sale_stock_picking_blocking,..

@gurneyalex
Copy link
Member

@nguyenminhchien I see other PRs on the same branch with green pre-commit checks. Can you try rebasing?

atchuthan and others added 17 commits April 11, 2024 09:35
@atchuthan @nguyenminhchien
[ADD] sale_exception
1dac1ed
@pedrobaeza @nguyenminhchien
[FIX] sale_exception: README
305f8fc
@atchuthan @nguyenminhchien
[FIX] sale_exception: configuration menu
711ca1f
@atchuthan @nguyenminhchien
[IMP] Rename action_cancel to action_draft to reset the flag
c9f2836
@TheCloneMaster @nguyenminhchien
[FIX] sale_exception: count stock from selected warehouse
63469a5 
Rule should only count available stock from selected warehouse from sale order.
Without warehouse in context, it currently sums all stock available in all warehouses.
@pedrobaeza @nguyenminhchien
sale_*: Fix parent menu
6119348 
The previous parent menu has an action attached, and with these modules,
it can't be clicked.
@mourad-ehm @nguyenminhchien
[FIX] add dependency to server-tools/base_exception
e9766b9
@mourad-ehm @nguyenminhchien
[FIX] sale_exception misc
cc4eafe 
* [FIX] sale_exception confirm wizard
* [FIX] add test of test_all_draft_orders & flake8 & readme.rst
* [FIX] improve codecov test
* [FIX] delete odl translation
* [FIX] add Camptocamp to author
* [FIX] readme.rst
@yvaucher @nguyenminhchien
[FIX] sale_exception constraint
9fcf1b3 
Raise SingletonError when you have a recordset with multiple sale order.
This restore the capability to write on multiple sale.order
@simahawk @nguyenminhchien
[11.0][MIG] sale_exception
e1a3c73
@simahawk @nguyenminhchien
sale_exception: recover translations from v10
189a284
@ivantodorovich @nguyenminhchien
[FIX] sale_exception: Menu location (OCA#719)
01f89a9 
Currently, it's located at the root menu because. It's a migration bug because the old menu was removed from 11.0.
@ljimenezsidoo @nguyenminhchien
Sale Exception to v12
7f044c9
@sebalix @nguyenminhchien
[MIG] sale_exception: Migration to 12.0
8ae6bfc
@sebalix @nguyenminhchien
[IMP] sale_exception: format XML file 'views/sale_view.xml'
ceddb23
@florian-dacosta @nguyenminhchien
Adapt sale_exception to base_exception simplification
b87dc59
@florian-dacosta @nguyenminhchien
Add test and fix apple and orange mixing error between sale order and…
1b7a40c 
… sale order line
mymage and others added 14 commits April 11, 2024 09:35
@mymage @nguyenminhchien
Translated using Weblate (Italian)
84f3d7b 
Currently translated at 16.6% (7 of 42 strings)

Translation: sale-workflow-16.0/sale-workflow-16.0-sale_exception
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_exception/it/
@sysadminmatmoz @nguyenminhchien
Translated using Weblate (Slovenian)
64f981f 
Currently translated at 16.6% (7 of 42 strings)

Translation: sale-workflow-16.0/sale-workflow-16.0-sale_exception
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_exception/sl/
@rousseldenis @nguyenminhchien
Translated using Weblate (French)
8687925 
Currently translated at 78.5% (33 of 42 strings)

Translation: sale-workflow-16.0/sale-workflow-16.0-sale_exception
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_exception/fr/
@glitchov @nguyenminhchien
Translated using Weblate (French)
a661d0e 
Currently translated at 78.5% (33 of 42 strings)

Translation: sale-workflow-16.0/sale-workflow-16.0-sale_exception
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_exception/fr/
@aliciagaarzo @nguyenminhchien
[16.0][IMP] sale_exception: Improved wizard view and don't ignore exc…
c057199 
…eptions with "is blocking" checked
@glitchov @nguyenminhchien
[FIX] sale_exception : so line decoration-danger condition
8004ecc
@OCA-git-bot @nguyenminhchien
sale_exception 16.0.1.1.0
e42ad66
@nguyenminhchien
[UPD] Update sale_exception.pot
11cf28d
@OCA-git-bot @nguyenminhchien
sale_exception 16.0.1.2.0
a64c377
@weblate @nguyenminhchien
Update translation files
a002d1b 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-16.0/sale-workflow-16.0-sale_exception
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_exception/
@glitchov @nguyenminhchien
Translated using Weblate (French)
c4742b7 
Currently translated at 83.7% (36 of 43 strings)

Translation: sale-workflow-16.0/sale-workflow-16.0-sale_exception
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_exception/fr/
@Ivorra78 @nguyenminhchien
Translated using Weblate (Spanish)
c66f4ca 
Currently translated at 100.0% (43 of 43 strings)

Translation: sale-workflow-16.0/sale-workflow-16.0-sale_exception
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_exception/es/
@OCA-git-bot @nguyenminhchien
[UPD] README.rst
ca4b246
@kikopeiro @nguyenminhchien
Translated using Weblate (Spanish)
f73a8bc 
Currently translated at 100.0% (43 of 43 strings)

Translation: sale-workflow-16.0/sale-workflow-16.0-sale_exception
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_exception/es/
@nguyenminhchien nguyenminhchien force-pushed the 17.0-mig-sale_exception branch from 83700ca to 828583d Compare April 11, 2024 02:36
@nguyenminhchien nguyenminhchien force-pushed the 17.0-mig-sale_exception branch from 828583d to 9f86dd2 Compare April 11, 2024 02:41
@nguyenminhchien
Copy link
Contributor Author

@nguyenminhchien I see other PRs on the same branch with green pre-commit checks. Can you try rebasing?

@gurneyalex hello, the checks are green now.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

1 similar comment
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@AndrzejGerasimukARCHIMEDES
Copy link

Can You tell me when You plan to merge it into R17?

@dreispt
Copy link
Member

dreispt commented Apr 28, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-2860-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 0d78bdc into OCA:17.0 Apr 28, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a8d1416. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@john-herholz-dt john-herholz-dt john-herholz-dt approved these changes

@gurneyalex gurneyalex gurneyalex approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.