[16.0][MIG] sale_order_price_recalculation #2778
Conversation
CRogos
force-pushed
the
16.0-mig-sale_order_price_recalculation
branch
6 times, most recently
from
7ee7ff7 to
7bea749
Compare
|
Has anyone an idea why this test is failing? When I run it locally the tests passes and also the module is working fine as far as I can say. |
…n demand sale order line prices ================================================== Recalculation of sale order lines prices on demand ================================================== This module adds a button on sale orders below pricelist that recalculates the prices of the order lines that contain a product in them. It is launched manually as a button to get the user decide if he/she wants to recalculate prices when pricelist is changed. Usage ===== Inside a sale order, you can click in any moment a button called "(Recalculate prices)", that is next to the pricelist selection, to launch a recalculation of all the prices of the lines, losing previous custom prices. Known issues / Roadmap ====================== * In a sale order with lot of lines, the recalculation may slow down, because sale general data (amount untaxed, amount taxed...) are recalculated for each line.
* add choice to recompute price only This commit add the capability to reset sale order line without renaming sale order lines * upgrade translation * Split functionnalities reset prices/reset desciptions * Move button under sale order lines
On certain set of installed modules, standard demo pricelist can be altered for giving something different than the list price, making these tests to fail. We avoid it creating our own pricelist with the fixed data that we want.
With current inheritance, the buttons are only visible if you have the security group "Lock Confirmed Sales" in your user. As we need to be seen in all cases, we modify the inheritance. TT37124
CRogos
force-pushed
the
16.0-mig-sale_order_price_recalculation
branch
from
7bea749 to
f77c300
Compare
|
Is the recalculate price obsolete? When switching the price list, there is an update button: |
CRogos
force-pushed
the
16.0-mig-sale_order_price_recalculation
branch
from
f77c300 to
2f68126
Compare
CRogos
force-pushed
the
16.0-mig-sale_order_price_recalculation
branch
from
2f68126 to
142f0bd
Compare
|
@arleite , @rousseldenis could you review this migration? |
|
@arleite can you also add yourself to the reviews? |
|
@arleite. I should have been more precise. You have to select "approve", not "comment". Thank you. |
|
@pedrobaeza could you merge? |
|
This module is outdated after the integration of the feature in core, and if you want it for the description thing, it should be renamed IMO. |
|
The update price button in the standard is not always visible and there is not possibility to reset the description. But I agree this feature mostly adds some UI improvements. The functionality is not changed, so I do not understand why we should change the name... but make a suggestion? |
|
I would maybe start from scratch a little module |
|
While refactoring this module I've exactly asked this question to my sales guys and they said that they are missing something like that. There themes to be a use case for that... but I agree that there could be a more beautiful solutions like these buttons. |
|
OK, you tell me then: should I press the button without thinking more? |
|
Yes please... anyone who has this module installed would be able to migrate to v16 without any functionality change. And Odoo has improved but does not fulfil the whole functionality. I agree that the module is now very small and maybe we can combine it with other functions in the future. |
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 8b63bf2. Thanks a lot for contributing to OCA. ❤️ |
supersede: #2605
Has anyone an idea what is wrong with the tests? Is this related to the hard disk swap outage?