Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] sale_order_line_input: Migration to version 16.0 #2687

Merged
merged 17 commits into from
Jan 18, 2024
Merged

[16.0][MIG] sale_order_line_input: Migration to version 16.0 #2687

merged 17 commits into from
Jan 18, 2024

Conversation

carolinafernandez-tecnativa
Copy link
Contributor

@carolinafernandez-tecnativa carolinafernandez-tecnativa commented Sep 13, 2023 •
edited
Loading

  • Standard migration to v16

@Tecnativa

TT44354

@pedrobaeza @carlosdauden

carlosdauden
carlosdauden suggested changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@carlosdauden carlosdauden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check that all the fields that are available in the "normal" view are present and check their attributes for similar behaviour.
https://github.com/odoo/odoo/blob/c77a8b4a35fb6ae62bb1824695563857b9e9116f/addons/sale/views/sale_views.xml#L458-L580

@carolinafernandez-tecnativa carolinafernandez-tecnativa force-pushed the 16.0-mig-sale_order_line_input branch 2 times, most recently from 96ce1b2 to ef7626e Compare September 14, 2023 09:29
@carolinafernandez-tecnativa
Copy link
Contributor Author

Check that all the fields that are available in the "normal" view are present and check their attributes for similar behaviour. https://github.com/odoo/odoo/blob/c77a8b4a35fb6ae62bb1824695563857b9e9116f/addons/sale/views/sale_views.xml#L458-L580

@carlosdauden fixed it! coudl you please check it now? Thanks!

@rousseldenis
Copy link
Contributor

/ocabot migration sale_order_line_input

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Sep 15, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Sep 15, 2023
Open
100 tasks
@carolinafernandez-tecnativa carolinafernandez-tecnativa force-pushed the 16.0-mig-sale_order_line_input branch 2 times, most recently from d14fabf to 017334e Compare September 20, 2023 12:19
@carolinafernandez-tecnativa
Copy link
Contributor Author

ping @carlosdauden

@carolinafernandez-tecnativa carolinafernandez-tecnativa force-pushed the 16.0-mig-sale_order_line_input branch 2 times, most recently from df14d80 to de69e50 Compare October 6, 2023 09:14
carlosdauden
carlosdauden suggested changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@carlosdauden carlosdauden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why has the force_company_id field functionality been removed?
#2687 (comment)
The only thing that needed to be removed was the line that took the force_company from the context:
or self.env.context.get("force_company")

@carolinafernandez-tecnativa
Copy link
Contributor Author

Why has the force_company_id field functionality been removed? #2687 (comment) The only thing that needed to be removed was the line that took the force_company from the context: or self.env.context.get("force_company")

Sorry I did not understand, could you please check it now?

@carolinafernandez-tecnativa
Copy link
Contributor Author

ping @carlosdauden

@pedrobaeza
Copy link
Member

@carolinafernandez-tecnativa please correctly put the changes on the corresponding commits.

@pedrobaeza
Copy link
Member

ping @carolinafernandez-tecnativa

@pedrobaeza pedrobaeza mentioned this pull request Jan 15, 2024
Closed
bhaveshselarka
bhaveshselarka approved these changes Jan 17, 2024
View reviewed changes
Copy link

@bhaveshselarka bhaveshselarka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

carlosdauden and others added 3 commits January 18, 2024 08:18
@carlosdauden @pedrobaeza
[ADD] sale_order_line_input: New module
c314c82 
[UPD] README.rst

[UPD] Update sale_order_line_input.pot
@pedrobaeza
[MIG] sale_order_line_input: migration to v12.0
3acb6fd
@rven @pedrobaeza
[MIG] sale_order_line_input: Migration to 12.0
2f83887 
[UPD] Update sale_order_line_input.pot

[UPD] README.rst

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_order_line_input
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_order_line_input/
marylla and others added 14 commits January 18, 2024 08:18
@marylla @pedrobaeza
Added translation using Weblate (German)
45100c2 
[UPD] README.rst
@liweijie0812 @pedrobaeza
Added translation using Weblate (Chinese (Simplified))
d7e02ee
@liweijie0812 @pedrobaeza
Translated using Weblate (Chinese (Simplified))
b940dd8 
Currently translated at 100.0% (17 of 17 strings)

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_order_line_input
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_order_line_input/zh_CN/

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_order_line_input
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_order_line_input/
@Rad0van @pedrobaeza
[IMP] sale_order_line_input: black, isort, prettier
330230f
@Rad0van @pedrobaeza
[MIG] sale_order_line_input: Migration to 13.0
e2f90d1 
[UPD] Update sale_order_line_input.pot

[UPD] README.rst
@gurneyalex @pedrobaeza
[FIX] sale_order_line_input: bump version
cc2c137 
to solve a pypi upload issue
@CarlosRoca13 @pedrobaeza
[FIX] sale_order_line_input: The field customer does not exist
1942c20 
Since v13 the customer field on res.partner model has been disappeared,
so when we try to add a value on the field order_partner_id we get an
error.

sale_order_line_input 13.0.1.1.0
@carlosdauden @pedrobaeza
[FIX] sale_order_line_input: company_id field is empty and multi-comp…
2502645 
…any domains don't work. Taxes empty
@bealdav @pedrobaeza
[MIG] sale_order_line_input: Migration to 14.0
6e5e5f3 
[MIG] sale_order_line_input: Migration to 14.0
@bealdav @pedrobaeza
IMP sale_order_line_input: add write_date on view
3d963bc 
[UPD] Update sale_order_line_input.pot

[UPD] README.rst

[IMP] update dotfiles [ci skip]

[UPD] README.rst

[UPD] README.rst
@victoralmau @pedrobaeza
[MIG] sale_order_line_input: Migration to 15.0
259e977 
TT36521
@carlosdauden @pedrobaeza
[FIX] sale_order_line_input: Administration/Settings group is require…
2e104dd 
…d to show order from order line
@pedrobaeza
[IMP] sale_order_line_input: pre-commit stuff
6fcdd79
@carolinafernandez-tecnativa @pedrobaeza
[MIG] sale_order_line_input: Migration to 16.0
5a97376
@pedrobaeza pedrobaeza force-pushed the 16.0-mig-sale_order_line_input branch from d6e086d to 5a97376 Compare January 18, 2024 07:21
@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-2687-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 741a641 into OCA:16.0 Jan 18, 2024
9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 3bd6ff5. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 16.0-mig-sale_order_line_input branch January 18, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis left review comments

@carlosdauden carlosdauden carlosdauden requested changes

@bhaveshselarka bhaveshselarka bhaveshselarka approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
merged 🎉 migration needs review
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.