-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
16.0 mig sale order line note #2616
base: 16.0
Are you sure you want to change the base?
16.0 mig sale order line note #2616
Conversation
Currently translated at 100.0% (5 of 5 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_order_line_note Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_order_line_note/ca/
Currently translated at 100.0% (5 of 5 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_order_line_note Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_order_line_note/es/
Currently translated at 100.0% (5 of 5 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_order_line_note Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_order_line_note/nl/
Currently translated at 100.0% (5 of 5 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_order_line_note Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_order_line_note/zh_CN/
/ocabot migration sale_order_line_note |
@aiendry-aktivsoftware Thanks for this. Could you do a better PR title ? Like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review. Minor comment
"license": "AGPL-3", | ||
"application": False, | ||
"installable": True, | ||
"external_dependencies": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove void entries
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with two nits:
- Squash commit noise? https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate
- It looks like this migration is from 14.0, skipping 15.0?
This PR has the |
Standard migration to version 16.0