Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][mig] sale_order_note_template #2612

Open
wants to merge 10 commits into
base: 16.0
Choose a base branch
from
Open

[16.0][mig] sale_order_note_template #2612

wants to merge 10 commits into from

Conversation

heliaktiv
Copy link
Contributor

No description provided.

@rousseldenis
Copy link
Contributor

/ocabot migration sale_order_note_template

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jul 24, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Jul 24, 2023
Open
100 tasks
rousseldenis
rousseldenis reviewed Jul 24, 2023
View reviewed changes
sale_order_note_template/tests/test_sale_order.py
@@ -14,7 +14,9 @@ def setUp(self):
self.sale_order = self.env.ref("sale.sale_order_2")

def test_on_change_term_template(self):
self.assertEqual(self.sale_order.note, "")
self.assertEqual(self.sale_order.note, False)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use self.assertFalse()

rousseldenis
rousseldenis approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@heliaktiv Could you squash your commits ?

PaulGoubert
PaulGoubert approved these changes Dec 4, 2023
View reviewed changes
Copy link

@PaulGoubert PaulGoubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreampiovesana
Copy link

@heliaktiv Could you squash your commits ?

can you?

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

1 similar comment
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulGoubert PaulGoubert PaulGoubert approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

Assignees
No one assigned
Labels
approved help wanted migration needs fixing needs review ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
8 participants
@heliaktiv @rousseldenis @andreampiovesana @OCA-git-bot @PaulGoubert @dreispt @petrus-v @oca-travis