-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0] [MIG] product_form_sale_link #2546
[16.0] [MIG] product_form_sale_link #2546
Conversation
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-13.0/sale-workflow-13.0-product_form_sale_link Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-product_form_sale_link/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-14.0/sale-workflow-14.0-product_form_sale_link Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-product_form_sale_link/
The button 'action_view_sales' is replaced in sale_stock, so it cannot be referenced.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-15.0/sale-workflow-15.0-product_form_sale_link Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-product_form_sale_link/
@@ -5,7 +5,6 @@ | |||
<record model="ir.ui.view" id="product_template_form_view"> | |||
<field name="name">product.template.form (in product_form_sale_link)</field> | |||
<field name="model">product.template</field> | |||
<field name="groups_id" eval="[(4, ref('sales_team.group_sale_salesman'))]" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is not valid. for people that are not member of group_sale_salesman, the field sale_lines_count will be displayed, but the button action_product_template_sale_list will be hidden.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@legalsylvain Since v16, groups are not allowed anymore on views. The field is in button, so it won't be displayed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh! thanks ! I had misread the xml code nesting.
CC : @rousseldenis |
/ocabot migration product_form_sale_link |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review
@@ -5,7 +5,6 @@ | |||
<record model="ir.ui.view" id="product_template_form_view"> | |||
<field name="name">product.template.form (in product_form_sale_link)</field> | |||
<field name="model">product.template</field> | |||
<field name="groups_id" eval="[(4, ref('sales_team.group_sale_salesman'))]" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh! thanks ! I had misread the xml code nesting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR has the |
/ocabot merge nobump |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at e3df9d1. Thanks a lot for contributing to OCA. ❤️ |
Migration product_form_sale_link from 15.0 to 16.0
--
Confermo di aver firmato il CLA https://odoo-community.org/page/cla e di aver letto le linee guida su https://odoo-community.org/page/contributing