Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0] [MIG] product_form_sale_link #2546

Merged
merged 23 commits into from
Jun 14, 2023

Conversation

GiuTav
Copy link
Contributor

@GiuTav GiuTav commented Jun 5, 2023

Migration product_form_sale_link from 15.0 to 16.0

--
Confermo di aver firmato il CLA https://odoo-community.org/page/cla e di aver letto le linee guida su https://odoo-community.org/page/contributing

rousseldenis and others added 23 commits June 5, 2023 10:04
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-13.0/sale-workflow-13.0-product_form_sale_link
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-product_form_sale_link/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-14.0/sale-workflow-14.0-product_form_sale_link
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-product_form_sale_link/
The button 'action_view_sales' is replaced in sale_stock, so it cannot be referenced.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-15.0/sale-workflow-15.0-product_form_sale_link
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-product_form_sale_link/
@@ -5,7 +5,6 @@
<record model="ir.ui.view" id="product_template_form_view">
<field name="name">product.template.form (in product_form_sale_link)</field>
<field name="model">product.template</field>
<field name="groups_id" eval="[(4, ref('sales_team.group_sale_salesman'))]" />
Copy link
Contributor

@legalsylvain legalsylvain Jun 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not valid. for people that are not member of group_sale_salesman, the field sale_lines_count will be displayed, but the button action_product_template_sale_list will be hidden.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@legalsylvain Since v16, groups are not allowed anymore on views. The field is in button, so it won't be displayed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! thanks ! I had misread the xml code nesting.

@legalsylvain
Copy link
Contributor

CC : @rousseldenis

@rousseldenis
Copy link
Contributor

/ocabot migration product_form_sale_link

Copy link
Contributor

@anmarmo1 anmarmo1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review

@@ -5,7 +5,6 @@
<record model="ir.ui.view" id="product_template_form_view">
<field name="name">product.template.form (in product_form_sale_link)</field>
<field name="model">product.template</field>
<field name="groups_id" eval="[(4, ref('sales_team.group_sale_salesman'))]" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! thanks ! I had misread the xml code nesting.

Copy link

@flalexg flalexg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review. LGTM!
The buttons are displayed well and show the correct information.
sales
sales2
When an user does not have permisions to entern sales, the button is correctly not displayed.
sales3

Copy link

@MarcoCalcagni MarcoCalcagni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rousseldenis
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-2546-by-rousseldenis-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 5f62c98 into OCA:16.0 Jun 14, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e3df9d1. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.