Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] sale_order_line_price_history: Migration to version 16.0 #2496

Merged
merged 18 commits into from
May 13, 2023

Conversation

Yadier-Tecnativa
Copy link
Contributor

@Tecnativa TT42430

ernestotejeda and others added 17 commits April 27, 2023 16:55
App price history of a product from a sale order line and set one of
this old prices in the sale order line.
Currently translated at 100.0% (29 of 29 strings)

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_order_line_price_history
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_order_line_price_history/es/
This way, the user doesn't have to save the line first to see the
customer prices.

TT29630
@Yadier-Tecnativa
Copy link
Contributor Author

ping @sergio-teruel , @pedrobaeza

@pedrobaeza
Copy link
Member

/ocabot migration sale_order_line_price_history

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Apr 28, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Apr 28, 2023
100 tasks
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JS code should be converted to new OWL

@Yadier-Tecnativa
Copy link
Contributor Author

JS code should be converted to new OWL

Done in sale_order_line_price_history/static/src/js/sale_line_price_history_widget.js

@Yadier-Tecnativa Yadier-Tecnativa force-pushed the 16.0-mig-sale_order_line_price_history branch from e945cc4 to 7be32b3 Compare May 4, 2023 21:09
@Yadier-Tecnativa Yadier-Tecnativa force-pushed the 16.0-mig-sale_order_line_price_history branch 2 times, most recently from 09e6754 to ac70f63 Compare May 6, 2023 16:41
@Yadier-Tecnativa Yadier-Tecnativa force-pushed the 16.0-mig-sale_order_line_price_history branch from ac70f63 to e9be72e Compare May 6, 2023 16:51
Migrate the SaleOrderLinePriceHistoryWidget to PriceHistoryWidget using the new OWL 16
@Yadier-Tecnativa Yadier-Tecnativa force-pushed the 16.0-mig-sale_order_line_price_history branch from e9be72e to a7664c7 Compare May 6, 2023 17:07
Copy link
Contributor

@sergio-teruel sergio-teruel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review ok

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-2496-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b67721a into OCA:16.0 May 13, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 116ddfb. Thanks a lot for contributing to OCA. ❤️

@sergio-teruel
Copy link
Contributor

ping @Juangomezzurita

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.