[16.0][mig] sale_last_price_info #2471

heliaktiv · 2023-04-11T10:57:09Z

No description provided.

Changed website in manifest

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-12.0/sale-workflow-12.0-sale_last_price_info Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_last_price_info/

Currently translated at 100.0% (7 of 7 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_last_price_info Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_last_price_info/es/

Currently translated at 100.0% (7 of 7 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_last_price_info Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_last_price_info/de/

Currently translated at 100.0% (7 of 7 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_last_price_info Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_last_price_info/zh_CN/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-13.0/sale-workflow-13.0-sale_last_price_info Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_last_price_info/

Currently translated at 100.0% (8 of 8 strings) Translation: sale-workflow-13.0/sale-workflow-13.0-sale_last_price_info Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_last_price_info/zh_CN/

Currently translated at 100.0% (8 of 8 strings) Translation: sale-workflow-13.0/sale-workflow-13.0-sale_last_price_info Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_last_price_info/es/

Currently translated at 100.0% (11 of 11 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_last_price_info Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_last_price_info/ca/

Currently translated at 100.0% (11 of 11 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_last_price_info Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_last_price_info/nl/

Currently translated at 72.7% (8 of 11 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_last_price_info Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_last_price_info/fr_FR/

Currently translated at 100.0% (8 of 8 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_last_price_info Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_last_price_info/fr/

Currently translated at 100.0% (8 of 8 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_last_price_info Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_last_price_info/de/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-15.0/sale-workflow-15.0-sale_last_price_info Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_last_price_info/

Currently translated at 100.0% (8 of 8 strings) Translation: sale-workflow-15.0/sale-workflow-15.0-sale_last_price_info Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_last_price_info/it/

rousseldenis · 2023-05-03T17:28:55Z

/ocabot migration sale_last_price_info

rousseldenis

Code review

rousseldenis · 2023-05-03T17:32:44Z

sale_last_price_info/__manifest__.py

+    "website": "https://github.com/OCA/sale-workflow",
+    "category": "Sales",
+    "license": "AGPL-3",
+    "contributors": [


This is not a valid entry. Should be in CONTRIBUTORS.rst only.

If some of them (or you) want to adopt as maintainer, you should add a "maintainers":[<github login>, ...]instead

rousseldenis · 2023-05-03T17:34:14Z

sale_last_price_info/models/product.py

+        """Get last sale price, last sale date and last customer"""
+        so_line_obj = self.env["sale.order.line"]
+        for product in self:
+            line = so_line_obj.search(


Something has to be done here as this will generate as many queries as products in recordset.

rousseldenis · 2023-05-03T17:35:38Z

sale_last_price_info/models/product.py

+                limit=1,
+                order="date_order_sale_last_price_info desc",
+            )
+            product.last_sale_date = fields.Datetime.to_string(


Suggested change

product.last_sale_date = fields.Datetime.to_string(

product.update({

"last_sale_date" : fields.Datetime.to_string(line.date_order_sale_last_price_info),

"last_sale_price": line.price_unit,

"last_customer_id": line.order_id.partner_id,

})

rousseldenis · 2023-05-03T17:37:19Z

sale_last_price_info/models/product.py

+            product.last_sale_price = line.price_unit
+            product.last_customer_id = line.order_id.partner_id
+
+    last_sale_price = fields.Float(compute="_compute_last_sale")


Fields definitions should be on top

rousseldenis · 2023-05-03T17:39:32Z

sale_last_price_info/tests/test_sale_last_price_info.py

+        self.price_unit = 100.0
+
+    def test_sale_last_price_info_demo(self):
+        sale_line = self.sale_line_model.search(


It's better to rely on new records created in test. Then, don't search but rely on the record values you've just created.

rousseldenis

Code and functional review

dreispt · 2023-12-27T14:52:54Z

/ocabot merge nobump

OCA-git-bot · 2023-12-27T14:53:35Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-2471-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot · 2023-12-27T15:05:32Z

Congratulations, your PR was merged at dc6b04d. Thanks a lot for contributing to OCA. ❤️

oihane and others added 30 commits April 11, 2023 16:09

[ADD] Moved <sale_last_price_info> from odoomrp-wip

ff89263

Slovene translations added

7e33b9a

OCA Transbot updated translations from Transifex

61a6ca6

[MIG] sale_last_price_info: Migration to 11.0

136fb09

[Imp]sale_last_price_info: Improved manifest

9b3c271

Changed website in manifest

[UPD] Update sale_last_price_info.pot

8d1bbee

[MIG] sale_last_price_info: Migration to 12.0

f946f34

[UPD] README.rst

b1279b0

[UPD] Update sale_last_price_info.pot

bab4f09

Translated using Weblate (Spanish)

03a6b8c

Currently translated at 100.0% (7 of 7 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_last_price_info Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_last_price_info/es/

Translated using Weblate (German)

641c79c

Currently translated at 100.0% (7 of 7 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_last_price_info Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_last_price_info/de/

[UPD] README.rst

a4f6eec

Added translation using Weblate (Chinese (Simplified))

f7ed09f

Migration sale_last_price_info from 12.0 to 13.0

92ae326

[UPD] Update sale_last_price_info.pot

e75234b

[UPD] README.rst

5490c82

pre-commit update

73b320d

Translated using Weblate (Spanish)

51d8bdd

Currently translated at 100.0% (8 of 8 strings) Translation: sale-workflow-13.0/sale-workflow-13.0-sale_last_price_info Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_last_price_info/es/

[MIG] sale_last_price_info: Migration to 14.0

65e49f6

[UPD] Update sale_last_price_info.pot

995e96e

sale_last_price_info 14.0.1.0.1

adc38d0

Added translation using Weblate (Catalan)

6f0b06d

Translated using Weblate (Catalan)

515101c

Currently translated at 100.0% (11 of 11 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_last_price_info Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_last_price_info/ca/

Added translation using Weblate (Dutch)

28deb21

Translated using Weblate (Dutch)

da5d56a

Currently translated at 100.0% (11 of 11 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_last_price_info Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_last_price_info/nl/

Added translation using Weblate (French (France))

9a76db8

Yvesldff and others added 11 commits April 11, 2023 16:09

Translated using Weblate (French)

930dbf4

Currently translated at 100.0% (8 of 8 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_last_price_info Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_last_price_info/fr/

Translated using Weblate (German)

d40fbd8

Currently translated at 100.0% (8 of 8 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_last_price_info Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_last_price_info/de/

[IMP] sale_last_price_info : black, isort, prettier

9450cd1

[MIG]sale_last_price_info: Migrate sale_last_price_info to v15.

4d51156

[UPD] Update sale_last_price_info.pot

42cefe4

[UPD] README.rst

8113c23

Translated using Weblate (Italian)

541e9af

Currently translated at 100.0% (8 of 8 strings) Translation: sale-workflow-15.0/sale-workflow-15.0-sale_last_price_info Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_last_price_info/it/

[IMP] sale_last_price_info: black, isort, prettier

de6413e

[MIG] sale_last_price_info: Migration to 16.0

350ccb7

OCA-git-bot added this to the 16.0 milestone May 3, 2023

OCA-git-bot mentioned this pull request May 3, 2023

Migration to version 16.0 #2215

Open

100 tasks

rousseldenis added needs review migration labels May 3, 2023

rousseldenis requested changes May 3, 2023

View reviewed changes

[MIG] sale_last_price_info: Migration to 16.0

c80ed35

rousseldenis approved these changes Aug 30, 2023

View reviewed changes

dreispt approved these changes Dec 27, 2023

View reviewed changes

OCA-git-bot added the approved label Dec 27, 2023

OCA-git-bot added the bot is merging ⏳ label Dec 27, 2023

OCA-git-bot merged commit 84a9949 into OCA:16.0 Dec 27, 2023
2 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Dec 27, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][mig] sale_last_price_info #2471

[16.0][mig] sale_last_price_info #2471

heliaktiv commented Apr 11, 2023

rousseldenis commented May 3, 2023

rousseldenis left a comment

rousseldenis May 3, 2023

rousseldenis May 3, 2023

rousseldenis May 3, 2023

rousseldenis May 3, 2023

rousseldenis May 3, 2023

rousseldenis left a comment

dreispt commented Dec 27, 2023

OCA-git-bot commented Dec 27, 2023

OCA-git-bot commented Dec 27, 2023

-            product.last_sale_date = fields.Datetime.to_string(
+            product.update({
+                "last_sale_date" : fields.Datetime.to_string(line.date_order_sale_last_price_info),
+                "last_sale_price": line.price_unit,
+                "last_customer_id": line.order_id.partner_id,
+            })

[16.0][mig] sale_last_price_info #2471

[16.0][mig] sale_last_price_info #2471

Conversation

heliaktiv commented Apr 11, 2023

rousseldenis commented May 3, 2023

rousseldenis left a comment

Choose a reason for hiding this comment

rousseldenis May 3, 2023

Choose a reason for hiding this comment

rousseldenis May 3, 2023

Choose a reason for hiding this comment

rousseldenis May 3, 2023

Choose a reason for hiding this comment

rousseldenis May 3, 2023

Choose a reason for hiding this comment

rousseldenis May 3, 2023

Choose a reason for hiding this comment

rousseldenis left a comment

Choose a reason for hiding this comment

dreispt commented Dec 27, 2023

OCA-git-bot commented Dec 27, 2023

OCA-git-bot commented Dec 27, 2023