[16.0][MIG] sale_invoice_plan: Migrate to 16.0

[MS-OSI]

Sales Invoice Plan

By standard feature, user can gradually create partial invoices, one by one.
This module add ability to create invoices based on the predefined invoice plan,
either all at once, or one by one.
The plan support both advance invoice and installment invoices.

[rousseldenis]

/ocabot migration sale_invoice_plan

[imlopes]

LGTM

[DigitalAutomations]

Any update about this?

[dreispt]

/ocabot merge nobump

[OCA-git-bot]

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-2438-by-dreispt-bump-nobump, awaiting test results.

[OCA-git-bot]

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-2438-by-dreispt-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

[dreispt]

Added forward port of #2408

[dreispt]

@kittiu I see you are the maintainer.
With just the basic migration to 16.0 this worked terribly wrong.
I added this fix to try make it work.

This migration might be worth deeper review and testing from you, if possible. Thanks!

[Borruso]

can you see this PR?
ursais#10

[kittiu]

@dreispt let me check.

@kittiu I see you are the maintainer. With just the basic migration to 16.0 this worked terribly wrong. I added this fix to try make it work.

This migration might be worth deeper review and testing from you, if possible. Thanks!

Sorry for delayed response, I will review this shortly. What is in the "fix" link, clicked and see nothing there.

[kittiu]

I think I found something. Let me explain.

We only use this module until version 14 without problem. I think bug about Advance was introduced in version 15, when following new fields was introduced.

https://github.com/OCA/sale-workflow/blob/15.0/sale_invoice_plan/models/sale.py#L28-L35

invoice_plan_total_percent and invoice_plan_total_amount -> trigger [sale.order]._compute_invoice_plan_total which also trigger [sale.order.plan]._compute_amount that mess up the percent.

OK the bug mentioned above was fixed here #2543

Let's merge it and cherry pick it here.

[dreispt]

@kittiu Thank you for looking into this.
You are right, I moved the changes to ursais#12
I also forward ported the 15.0 fix you mentioned.

[kittiu]

Hello,

As I come back to check this module, sale_invoice_plan. I tested that everything including Advance works fine on version 14 and 15.
But when I migrate 15 to 16, the Advance is not working correctly. So, I think there must be changes on Odoo core.

I want to propose to close this PR first, and I will do the fresh upgrade from 15 to 16 make sure everything works according to its normality. Then, if you have any other features to add, you can do in separated PR (so it can be backport too)

cc @dreispt @MS-OSI

[kittiu]

Here the new PR with minimum fix to make it works as in previous version #2988

[kittiu]

@MS-OSI can you help closing this one? Thanks!

[kittiu]

Can anyone help closing this PR please. Thanks!

[DigitalAutomations]

Any udpdate?
What is the correct pr to test ?

[Saran440]

@DigitalAutomations you can test PR #2988