[16.0][MIG] sale_order_tag #2364
Conversation
This module adds tags to sales order. The tags are for independant to sales orders and not related to the opportunities like the other tag field that exists. [IMP] domain fix and better readme description Update __manifest__.py Co-authored-by: Bhavesh Odedra <[email protected]> Update tag string Co-authored-by: Bhavesh Odedra <[email protected]> [FIX] Readme LINT [FIX] Reviewer suggestions - Removed plural on saleordertag class - Moved menu item to proper xml - Added company_id field to tags with rule - Moved sequence to data - Additional code cleanup [FIX] Typo
Currently translated at 100.0% (20 of 20 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_order_tag Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_order_tag/it/
|
/ocabot migration sale_order_tag |
|
@Kev-Roche Thanks for this. Could you follow migration guide especially the full process part ? https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-16.0 In fact, the setup/pre-commit stuff should go in a separate commit |
Kev-Roche
force-pushed
the
16.0-mig-sale_order_tag
branch
from
7ad285a to
ab563cb
Compare
|
@rousseldenis done, sorry for the delay. |
There was a problem hiding this comment.
@Kev-Roche Could you rearrange your changes in commits ?
In pre-commit should go ... pre-commit stuffs and in migration one, guess 😃
Thanks
sale_order_tag/__manifest__.py
Outdated
| @@ -7,7 +7,7 @@ | |||
| "author": "Patrick Wilson, Odoo Community Association (OCA)", | |||
| "website": "https://github.com/OCA/sale-workflow", | |||
| "category": "Sale", | |||
| "version": "14.0.1.0.1", | |||
| "version": "16.0.0.0.1", | |||
There was a problem hiding this comment.
This should be 16.0.1.0.0
| required=True, | ||
| ) | ||
|
|
||
| _sql_constraints = [("name_uniq", "unique (name)", "Tag name already exists!")] |
There was a problem hiding this comment.
Maybe it could be interesting to make tag names unique per company
There was a problem hiding this comment.
Indeed, I added it, thank you.
Kev-Roche
force-pushed
the
16.0-mig-sale_order_tag
branch
2 times, most recently
from
374077b to
5141eb2
Compare
Kev-Roche
force-pushed
the
16.0-mig-sale_order_tag
branch
from
5141eb2 to
0777a45
Compare
|
pretty much everything in the pre-commit commit except the |
|
/ocabot rebase |
|
Sorry @ChrisOForgeFlow you are not allowed to rebase. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
|
@Kev-Roche can you rebase PR please? |
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
This PR has the |
|
Congratulations, your PR was merged at 490b873. Thanks a lot for contributing to OCA. ❤️ |
Migration of sale_order_tag from 14.0
Change menu name "Tags" into "Sale Order Tags" to avoid duplicate name with "Tags" from crm