Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG][16.0] sale_force_invoiced #2305

Merged
merged 37 commits into from
Jun 6, 2023

Conversation

alexis-via
Copy link
Contributor

2 small improvements:

  • force_invoiced is now tracked in the chatter (important !)
  • force_invoiced is invisible on quotations

JordiBForgeFlow and others added 30 commits December 14, 2022 15:45
* [ADD] module 'sale_force_invoiced' for 9.0

* [FIX] Travis
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_force_invoiced
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_force_invoiced/
Currently translated at 100.0% (3 of 3 strings)

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_force_invoiced
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_force_invoiced/de/
Currently translated at 100.0% (3 of 3 strings)

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_force_invoiced
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_force_invoiced/zh_CN/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-13.0/sale-workflow-13.0-sale_force_invoiced
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_force_invoiced/
Currently translated at 100.0% (3 of 3 strings)

Translation: sale-workflow-13.0/sale-workflow-13.0-sale_force_invoiced
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_force_invoiced/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-13.0/sale-workflow-13.0-sale_force_invoiced
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_force_invoiced/
Currently translated at 100.0% (3 of 3 strings)

Translation: sale-workflow-13.0/sale-workflow-13.0-sale_force_invoiced
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_force_invoiced/ca/
Sometimes you have a SO that Odoo computes as "Nothing to invoice"
but you want to force it to "Fully invoiced" anyway.

Example: SO with 2 lines, line one is delivered and invoiced,
second line is never going to be delivered nor invoiced (
because of different bussiness reasons). In this situation you
still want to mark the SO as fully invoiced.
Currently translated at 100.0% (3 of 3 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_force_invoiced
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_force_invoiced/fr/
@alexis-via alexis-via force-pushed the 16-mig-sale_force_invoiced branch from b1dc575 to 71f1ca1 Compare December 14, 2022 23:46
@rousseldenis
Copy link
Contributor

/ocabot migration sale_force_invoiced

def _get_invoice_status(self):
res = super(SaleOrder, self)._get_invoice_status()
def _compute_invoice_status(self):
res = super()._compute_invoice_status()
for order in self.filtered(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexis-via You can improve:

self.filtered(lambda so: so.force_invoiced and so.state in ("sale", "done")).update({"invoice_status": "invoiced"})

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexis-via can you add it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine @alexis-via. Can you add this change?

Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@pedrobaeza
Copy link
Member

/ocabot migration sale_force_invoiced

@OCA-git-bot
Copy link
Contributor

The migration issue (#2215) has been updated to reference the current pull request.
however, a previous pull request was referenced : #2472.
Perhaps you should check that there is no duplicate work.
CC : @Highcooley

Copy link
Contributor

@ferran-S73 ferran-S73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review OK

Copy link

@Highcooley Highcooley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review OK

The force_invoiced field is now tracked in the chatter and hidden on quotations
@alexis-via alexis-via force-pushed the 16-mig-sale_force_invoiced branch from 71f1ca1 to 6e0be0e Compare June 6, 2023 13:21
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@StefanRijnhart
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-2305-by-StefanRijnhart-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b9c520b into OCA:16.0 Jun 6, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at cf6a113. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.