-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIG][16.0] sale_force_invoiced #2305
Conversation
* [ADD] module 'sale_force_invoiced' for 9.0 * [FIX] Travis
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-12.0/sale-workflow-12.0-sale_force_invoiced Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_force_invoiced/
Currently translated at 100.0% (3 of 3 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_force_invoiced Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_force_invoiced/de/
Currently translated at 100.0% (3 of 3 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_force_invoiced Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_force_invoiced/zh_CN/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-13.0/sale-workflow-13.0-sale_force_invoiced Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_force_invoiced/
Currently translated at 100.0% (3 of 3 strings) Translation: sale-workflow-13.0/sale-workflow-13.0-sale_force_invoiced Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_force_invoiced/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-13.0/sale-workflow-13.0-sale_force_invoiced Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_force_invoiced/
Currently translated at 100.0% (3 of 3 strings) Translation: sale-workflow-13.0/sale-workflow-13.0-sale_force_invoiced Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_force_invoiced/ca/
Sometimes you have a SO that Odoo computes as "Nothing to invoice" but you want to force it to "Fully invoiced" anyway. Example: SO with 2 lines, line one is delivered and invoiced, second line is never going to be delivered nor invoiced ( because of different bussiness reasons). In this situation you still want to mark the SO as fully invoiced.
Currently translated at 100.0% (3 of 3 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_force_invoiced Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_force_invoiced/fr/
b1dc575
to
71f1ca1
Compare
/ocabot migration sale_force_invoiced |
def _get_invoice_status(self): | ||
res = super(SaleOrder, self)._get_invoice_status() | ||
def _compute_invoice_status(self): | ||
res = super()._compute_invoice_status() | ||
for order in self.filtered( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexis-via You can improve:
self.filtered(lambda so: so.force_invoiced and so.state in ("sale", "done")).update({"invoice_status": "invoiced"})
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexis-via can you add it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks fine @alexis-via. Can you add this change?
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
/ocabot migration sale_force_invoiced |
The migration issue (#2215) has been updated to reference the current pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review OK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review OK
The force_invoiced field is now tracked in the chatter and hidden on quotations
71f1ca1
to
6e0be0e
Compare
This PR has the |
/ocabot merge nobump |
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at cf6a113. Thanks a lot for contributing to OCA. ❤️ |
2 small improvements: