[14.0][FIX] product_form_sale_link: replace sales_count by a coherent one #2120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiquelRForgeFlow
force-pushed
the
14.0-ref-product_form_sale_link
branch
from
3a1a695 to
008673f
Compare
The sales_count field is already used in odoo for another button, which calculates the sum of the quantity of that product for each sale line instead of the number of sale lines. Now, the number in the button show the correct number of sale lines.
mariadforgeflow
force-pushed
the
14.0-ref-product_form_sale_link
branch
from
008673f to
11cf175
Compare
|
This PR has the |
|
/ocabot merge minor |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at eea10da. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sales_count field is already used in odoo for another button, which calculates the sum of the "product_uom_qty" of that product for each sale line instead of the number of sale lines.
Now, the number in the button show the correct number of sale lines.