Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[portal_sale_personal_data_only] Split for sale and invoice #2236

Closed
rafaelbn opened this issue Oct 19, 2022 · 2 comments · Fixed by #2243
Closed

[portal_sale_personal_data_only] Split for sale and invoice #2236

rafaelbn opened this issue Oct 19, 2022 · 2 comments · Fixed by #2243
Labels
enhancement
Milestone
15.0

Comments

@rafaelbn
Copy link
Member

Hello,

Module portal_sale_personal_data_only includes security rules for sales and invoices and it forces to depend in sales

Sales: https://github.com/OCA/sale-workflow/blob/14.0/portal_sale_personal_data_only/security/security.xml#L3

Invoices: https://github.com/OCA/sale-workflow/blob/14.0/portal_sale_personal_data_only/security/security.xml#L19

We have the use case with the same problem (IMHO a Odoo BUG...) but client don't use sales, just invoicing.

I guess it's not a problem and in fact make sense to split it.

Do you agree?

cc @pedrobaeza @chienandalu @victoralmau @kirca (last PRs I saw)
@rafaelbn rafaelbn added this to the 15.0 milestone Oct 19, 2022
@pedrobaeza
Copy link
Member

A split adding portal_account_personal_data_only seems OK.

yajo added a commit to moduon/sale-workflow that referenced this issue Oct 26, 2022
@yajo
[REF] portal_sale_personal_data_only: outsource invoice features
394e2ba 
Fix OCA#2236 by extracting these features into a separate module.

The module is attempted to be installed, but it won't fail if it is not found.
yajo added a commit to moduon/sale-workflow that referenced this issue Oct 26, 2022
@yajo
[REF] portal_sale_personal_data_only: outsource invoice features
f20faeb 
Fix OCA#2236 by extracting these features into the new module `portal_account_personal_data_only`.

The module now depends on it and is auto-installed if `sale` is also installed.

@moduon MT-1451
yajo added a commit to moduon/account-invoicing that referenced this issue Oct 26, 2022
@yajo
[ADD] portal_account_personal_data_only: display only own invoices in…
40a53be 
… portal

This module is half of the fix for OCA/sale-workflow#2236.

Extracts only the account part of `portal_sale_personal_data_only` as it was in previous versions.

@moduon MT-1451
This was referenced Oct 26, 2022
Merged
Merged
@yajo
Copy link
Member

yajo commented Oct 26, 2022

MIG+REF in OCA/account-invoicing#1275 and #2243.

@yajo yajo linked a pull request Oct 26, 2022 that will close this issue
[15.0][MIG+REF] portal_sale_personal_data_only: Migration to 15.0 and split in two #2243
Merged
yajo added a commit to moduon/account-invoicing that referenced this issue Oct 27, 2022
@yajo
[ADD] portal_account_personal_data_only: display only own invoices in…
32b8352 
… portal

This module is half of the fix for OCA/sale-workflow#2236.

Extracts only the account part of `portal_sale_personal_data_only` as it was in previous versions.

Tests adapted.

@moduon MT-1451
yajo added a commit to moduon/account-invoicing that referenced this issue Oct 27, 2022
@yajo
[ADD] portal_account_personal_data_only: display only own invoices in…
1a239e4 
… portal

This module is half of the fix for OCA/sale-workflow#2236.

Extracts only the account part of `portal_sale_personal_data_only` as it was in previous versions.

Tests adapted.

@moduon MT-1451
yajo added a commit to moduon/account-invoicing that referenced this issue Oct 28, 2022
@yajo
[ADD] portal_account_personal_data_only: display only own invoices in…
7cc18ca 
… portal

This module is half of the fix for OCA/sale-workflow#2236.

Extracts only the account part of `portal_sale_personal_data_only` as it was in previous versions.

Tests adapted.

@moduon MT-1451
yajo added a commit to moduon/sale-workflow that referenced this issue Oct 31, 2022
@yajo
[REF] portal_sale_personal_data_only: outsource invoice features
ca43dc6 
Fix OCA#2236 by extracting these features into the new module `portal_account_personal_data_only`.

The module now depends on it and is auto-installed if `sale` is also installed.

@moduon MT-1451
yajo added a commit to moduon/sale-workflow that referenced this issue Oct 31, 2022
@yajo
[REF] portal_sale_personal_data_only: outsource invoice features
f6dae55 
Fix OCA#2236 by extracting these features into the new module `portal_account_personal_data_only`.

The module now depends on it and is auto-installed if `sale` is also installed.

@moduon MT-1451
yajo added a commit to moduon/sale-workflow that referenced this issue Nov 9, 2022
@yajo
[REF] portal_sale_personal_data_only: outsource invoice features
aa6df45 
Fix OCA#2236 by extracting these features into the new module `portal_account_personal_data_only`.

The module now depends on it and is auto-installed if `sale` is also installed.

@moduon MT-1451
pilarvargas-tecnativa pushed a commit to Tecnativa/sale-workflow that referenced this issue Feb 7, 2023
@yajo
[REF] portal_sale_personal_data_only: outsource invoice features
392ad4c 
Fix OCA#2236 by extracting these features into the new module `portal_account_personal_data_only`.

The module now depends on it and is auto-installed if `sale` is also installed.

@moduon MT-1451
stefan-tecnativa pushed a commit to Tecnativa/account-invoicing that referenced this issue Oct 26, 2023
@yajo @stefan-tecnativa
[ADD] portal_account_personal_data_only: display only own invoices in…
dc37544 
… portal

This module is half of the fix for OCA/sale-workflow#2236.

Extracts only the account part of `portal_sale_personal_data_only` as it was in previous versions.

Tests adapted.

@moduon MT-1451
stefan-tecnativa pushed a commit to Tecnativa/sale-workflow that referenced this issue Oct 26, 2023
@yajo @stefan-tecnativa
[REF] portal_sale_personal_data_only: outsource invoice features
7ee0615 
Fix OCA#2236 by extracting these features into the new module `portal_account_personal_data_only`.

The module now depends on it and is auto-installed if `sale` is also installed.

@moduon MT-1451
Ricardoalso pushed a commit to camptocamp/sale-workflow that referenced this issue Nov 27, 2023
@yajo @Ricardoalso
[REF] portal_sale_personal_data_only: outsource invoice features
faaef11 
Fix OCA#2236 by extracting these features into the new module `portal_account_personal_data_only`.

The module now depends on it and is auto-installed if `sale` is also installed.

@moduon MT-1451
Ricardoalso pushed a commit to camptocamp/sale-workflow that referenced this issue Nov 27, 2023
@yajo @Ricardoalso
[REF] portal_sale_personal_data_only: outsource invoice features
3f99be9 
Fix OCA#2236 by extracting these features into the new module `portal_account_personal_data_only`.

The module now depends on it and is auto-installed if `sale` is also installed.

@moduon MT-1451
Ricardoalso pushed a commit to camptocamp/sale-workflow that referenced this issue Nov 27, 2023
@yajo @Ricardoalso
[REF] portal_sale_personal_data_only: outsource invoice features
b4a86d1 
Fix OCA#2236 by extracting these features into the new module `portal_account_personal_data_only`.

The module now depends on it and is auto-installed if `sale` is also installed.

@moduon MT-1451
SodexisTeam pushed a commit to sodexis/account-invoicing that referenced this issue Aug 28, 2024
@yajo
[ADD] portal_account_personal_data_only: display only own invoices in…
cdf57d1 
… portal

This module is half of the fix for OCA/sale-workflow#2236.

Extracts only the account part of `portal_sale_personal_data_only` as it was in previous versions.

Tests adapted.

@moduon MT-1451
SodexisTeam pushed a commit to sodexis/sale-workflow that referenced this issue Sep 3, 2024
@yajo
[REF] portal_sale_personal_data_only: outsource invoice features
2f147e7 
Fix OCA#2236 by extracting these features into the new module `portal_account_personal_data_only`.

The module now depends on it and is auto-installed if `sale` is also installed.

@moduon MT-1451
OCA-git-bot pushed a commit that referenced this issue Nov 29, 2024
@yajo @victoralmau
[REF] portal_sale_personal_data_only: outsource invoice features
bc7b65a 
Fix #2236 by extracting these features into the new module `portal_account_personal_data_only`.

The module now depends on it and is auto-installed if `sale` is also installed.

@moduon MT-1451
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
15.0
3 participants
@yajo @pedrobaeza @rafaelbn