Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][MIG] project_role #949

Merged
merged 56 commits into from
Jul 26, 2022
Merged

Conversation

alexey-pelykh
Copy link
Contributor

No description provided.

alexey-pelykh and others added 30 commits July 25, 2022 18:36
Currently translated at 100.0% (61 of 61 strings)

Translation: project-12.0/project-12.0-project_role
Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_role/de/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: project-12.0/project-12.0-project_role
Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_role/
Currently translated at 100.0% (67 of 67 strings)

Translation: project-12.0/project-12.0-project_role
Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_role/sl/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: project-12.0/project-12.0-project_role
Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_role/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: project-12.0/project-12.0-project_role
Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_role/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: project-12.0/project-12.0-project_role
Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_role/
@alexey-pelykh alexey-pelykh force-pushed the 15.0-mig-project_role branch 2 times, most recently from 1bb70df to c765441 Compare July 25, 2022 16:48
@alexey-pelykh
Copy link
Contributor Author

@rafaelbn @ajaniszewska-dev @bizzappdev please transfer your opinions here

@rafaelbn rafaelbn added this to the 15.0 milestone Jul 25, 2022
Copy link
Contributor

@bizzappdev bizzappdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajaniszewska-dev
Copy link
Contributor

ajaniszewska-dev commented Jul 26, 2022

migration commit should be according to template: [MIG] $MODULE: Migration to 15.0, same for PR title.

@alexey-pelykh
Copy link
Contributor Author

alexey-pelykh commented Jul 26, 2022

@ajaniszewska-dev it is?
image

As for the PR title - can you please point me to the rule/requirement in the guidelines, would be great to enhance my knowledge of those.

@ajaniszewska-dev
Copy link
Contributor

ajaniszewska-dev commented Jul 26, 2022

@ajaniszewska-dev it is? image

As for the PR title - can you please point me to the rule/requirement in the guidelines, would be great to enhance my knowledge of those.

@alexey-pelykh yes - sorry, my bad. but change PR title accordingly please. it is not a strict requirement there but i faced problems because of that when i wanted to merge my OCA PRs recently.

Guideline: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-15.0

@alexey-pelykh
Copy link
Contributor Author

alexey-pelykh commented Jul 26, 2022

@ajaniszewska-dev sorry, yet I fail to find line in the guide PR title, please point me to the specific line. Also, regarding the issues you've encountered in your PRs - out of curiosity, what PRs are those?

@ajaniszewska-dev
Copy link
Contributor

@ajaniszewska-dev sorry, yet I fail to find line in the guide PR title, please point me to the specific line. Also, regarding the issues you've encountered in your PRs - out of curiosity, what PRs are those?

it is fine as it is, i was looking on wrong commit.

@alexey-pelykh
Copy link
Contributor Author

/ocabot migration project_role
/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-949-by-alexey-pelykh-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

The migration issue (#859) has been updated to reference the current pull request.
however, a previous pull request was referenced : #896.
Perhaps you should check that there is no duplicate work.
CC : @bizzappdev

@alexey-pelykh
Copy link
Contributor Author

@ajaniszewska-dev tbh, I'm not sure that demand if you got one about PR title was reasonable, so just curious what PSC team was going for that

@OCA-git-bot OCA-git-bot merged commit 66587bf into OCA:15.0 Jul 26, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e51d93e. Thanks a lot for contributing to OCA. ❤️

@alexey-pelykh alexey-pelykh deleted the 15.0-mig-project_role branch July 26, 2022 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.