Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][MIG] project_template: migration to 15.0 #887

Merged
merged 42 commits into from
Apr 11, 2022
Merged

[15.0][MIG] project_template: migration to 15.0 #887

merged 42 commits into from
Apr 11, 2022

Conversation

Mantux11
Copy link

@Mantux11 Mantux11 commented Jan 25, 2022

Standard migration to version 15.0. Odoo deleted subtask project's, so there is made changes also. We don't need to create like a Subtask Project anymore.

patrickrwilson and others added 30 commits January 25, 2022 08:43
Adding new Project Template Module

[FIX] PEP8 Errors

Revert "[FIX] PEP8 Errors"

This reverts commit 90f9cd9.

[FIX] Fixed PEP8 Formatting

First upload tests showed some lint issues which this commit has the fixes for.

[FIX] Fixed LINT Issue

Removed unreachable code that was not needed.

[FIX] RunBot Warning

Fixed runbot warning about @Class to hasclass

[UPD] Suggested Changes

Updated based on suggested changes on other submitted modules.

[UPD] Manifest and Readme

Updated Manifest and Readme based on comments on other module pr's.

[UPD] Suggested Changes

Updated code based on suggested code changes from reviewer.

[FIX] Creation Error

Fixed create project error when creating project via configuration/projects menu

[UPD] Menu and Bool Change

Removed Template Menu (Filter option still there) and moved Bool up below name. (From reviewer suggestions)

[UPD] Kanban Menu

Removed button, added link to kanban menu. Start of tests

[UPD] Remove project_milestone code

Removed the project_milestone code and will create a separate module for that purpose.
Currently translated at 100.0% (7 of 7 strings)

Translation: project-12.0/project-12.0-project_template
Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_template/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: project-12.0/project-12.0-project_template
Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_template/
There is an error if the template name gets modified so needed to add a new else statement for the new_name.
Currently translated at 100.0% (7 of 7 strings)

Translation: project-12.0/project-12.0-project_template
Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_template/pt/
Currently translated at 85.7% (6 of 7 strings)

Translation: project-12.0/project-12.0-project_template
Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_template/fr/
Currently translated at 100.0% (7 of 7 strings)

Translation: project-12.0/project-12.0-project_template
Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_template/sl/
Currently translated at 14.3% (1 of 7 strings)

Translation: project-12.0/project-12.0-project_template
Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_template/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: project-13.0/project-13.0-project_template
Translate-URL: https://translation.odoo-community.org/projects/project-13-0/project-13-0-project_template/
Currently translated at 100.0% (7 of 7 strings)

Translation: project-13.0/project-13.0-project_template
Translate-URL: https://translation.odoo-community.org/projects/project-13-0/project-13-0-project_template/he/
OCA-git-bot and others added 12 commits January 25, 2022 08:43
Currently translated at 100.0% (10 of 10 strings)

Translation: project-14.0/project-14.0-project_template
Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_template/es_AR/
Currently translated at 100.0% (7 of 7 strings)

Translation: project-14.0/project-14.0-project_template
Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_template/fr/
Currently translated at 70.0% (7 of 10 strings)

Translation: project-14.0/project-14.0-project_template
Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_template/fr_FR/
Currently translated at 100.0% (10 of 10 strings)

Translation: project-14.0/project-14.0-project_template
Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_template/de/
Currently translated at 100.0% (10 of 10 strings)

Translation: project-14.0/project-14.0-project_template
Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_template/sv/
Since in  original odoo `15.0` version project subtasks
has been deleted so changes also done in this module.
We don't need project subtasks anymore because odoo don't have it.
@Mantux11 Mantux11 mentioned this pull request Jan 25, 2022
32 tasks
@sbidoul
Copy link
Member

sbidoul commented Jan 25, 2022

/ocabot migration project_template

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Jan 25, 2022
Copy link
Member

@sbidoul sbidoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review and functional test by end customer.

Thanks for the migration.

This module is english-only in the way it handles (TEMPLATE) and (COPY), but that is an issue which is unrelated to the migration.

@BT-cserra
Copy link

Hello @sbidoul & @gaikaz, can we trigger a merge on this one? Thank you and have a GREAT DAY.

@BT-fgarbely
Copy link

Hello @patrickrwilson @dreispt

What is the state here? Can this PR be merged?
Thanks for checking.

Have a nice day

@dreispt
Copy link
Member

dreispt commented Mar 24, 2022

/ocabot merge nobump

@BT-cserra
Copy link

/ocabot merge nobump

Hello @dreispt . The merge command failed (or: it did nothing, or nothing that I can see). Can you please try again? Many thanks.

@dreispt
Copy link
Member

dreispt commented Apr 11, 2022

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-887-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit cf78341 into OCA:15.0 Apr 11, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a9fdafb. Thanks a lot for contributing to OCA. ❤️

@gaikaz gaikaz deleted the 15.0-mig-project_template branch April 12, 2022 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.