[FIX] project_timesheet_time_control: Condition always gets evaluated as False #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrobaeza
requested changes
Sep 27, 2017
| @@ -32,7 +32,7 @@ def onchange_task_id(self): | |||
| self.project_id = self.task_id.project_id.id | |||
|
|
|||
| def eval_date(self, vals): | |||
| if 'date_time' in vals and 'date' not in vals: | |||
| if vals.get('date_time', False): | |||
There was a problem hiding this comment.
Please change it then to if 'date_time' in vals and vals.get('date_time'):
|
Done |
pedrobaeza
approved these changes
Sep 27, 2017
carlosdauden
approved these changes
Sep 27, 2017
| @@ -32,7 +32,7 @@ def onchange_task_id(self): | |||
| self.project_id = self.task_id.project_id.id | |||
|
|
|||
| def eval_date(self, vals): | |||
| if 'date_time' in vals and 'date' not in vals: | |||
| if 'date_time' in vals and vals.get('date_time'): | |||
There was a problem hiding this comment.
I think that get is not needed in this case.
if 'date_time' in vals and vals['date_time']:
There was a problem hiding this comment.
Actually removing the first part and leaving the get would be functionally equivalent and cleaner:
if vals.get('date_time'):
There was a problem hiding this comment.
Well, I wanted to avoid the None case, but you're right. It was correct the first time.
There was a problem hiding this comment.
Ok, I'm going to change it as @lasley says.
ernestotejeda
pushed a commit
to ernestotejeda/project
that referenced
this pull request
Jun 25, 2018
ernestotejeda
pushed a commit
to ernestotejeda/project
that referenced
this pull request
Jun 26, 2018
pedrobaeza
pushed a commit
to ernestotejeda/project
that referenced
this pull request
Aug 8, 2018
ernestotejeda
pushed a commit
to Tecnativa/project
that referenced
this pull request
Nov 12, 2018
ernestotejeda
pushed a commit
to Tecnativa/project
that referenced
this pull request
Jan 14, 2019
alexey-pelykh
pushed a commit
to brainbeanapps/project
that referenced
this pull request
Feb 12, 2019
fuentes73
added a commit
to Studio73/project
that referenced
this pull request
Apr 27, 2019
alexey-pelykh
pushed a commit
to brainbeanapps/project
that referenced
this pull request
Jun 5, 2019
ernestotejeda
pushed a commit
to Tecnativa/project
that referenced
this pull request
Aug 27, 2019
OCA-git-bot
pushed a commit
that referenced
this pull request
Aug 29, 2019
manuelcalerosolis
pushed a commit
to Tecnativa/project
that referenced
this pull request
Feb 26, 2020
pedrobaeza
pushed a commit
to Tecnativa/project
that referenced
this pull request
Jul 7, 2020
watthanun
pushed a commit
to ecosoft-odoo/project
that referenced
this pull request
Dec 23, 2020
manuelcalerosolis
pushed a commit
to xtendoo-corporation/project
that referenced
this pull request
Jun 28, 2022
vincent-hatakeyama
pushed a commit
to xcgd/project
that referenced
this pull request
Sep 28, 2022
CarlosRoca13
pushed a commit
to Tecnativa/project
that referenced
this pull request
Oct 5, 2022
CarlosRoca13
pushed a commit
to Tecnativa/project
that referenced
this pull request
Nov 7, 2022
daramousk
pushed a commit
to daramousk/project
that referenced
this pull request
May 26, 2023
heliaktiv
pushed a commit
to heliaktiv/project
that referenced
this pull request
Jun 6, 2023
stefan-tecnativa
pushed a commit
to Tecnativa/project
that referenced
this pull request
Jul 6, 2023
pedrobaeza
pushed a commit
to Tecnativa/project
that referenced
this pull request
Aug 1, 2023
Ricardoalso
pushed a commit
to camptocamp/project
that referenced
this pull request
Oct 6, 2023
Ricardoalso
pushed a commit
to camptocamp/project
that referenced
this pull request
Oct 6, 2023
chandni-serpentcs
pushed a commit
to chandni-serpentcs/project
that referenced
this pull request
Jan 9, 2024
mde-scopea
pushed a commit
to mde-scopea/project
that referenced
this pull request
Jan 31, 2024
RogerSans
pushed a commit
to sygel-technology/project
that referenced
this pull request
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
We've notice that if a new analytic line is created with a date_time different from today. The field date is never equals to field date_time, because date has a default value defined at analytic module. So the condition in eval_date function is always evaluated as False