Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][MIG] project_stock: Migration to 15.0 #1020

Merged
merged 22 commits into from
Nov 9, 2022

Conversation

victoralmau
Copy link
Member

@victoralmau victoralmau commented Nov 4, 2022

Migration to 15.0

Please @pedrobaeza and @chienandalu can you review it?

@Tecnativa TT40363

@victoralmau victoralmau force-pushed the 15.0-mig-project_stock branch 2 times, most recently from fabb88e to 691e6c7 Compare November 4, 2022 15:55
victoralmau and others added 21 commits November 4, 2022 17:16
TT34554

[UPD] Update project_stock.pot

[UPD] README.rst
…e access to stock.

TT35899

project_stock 13.0.1.1.0
…ailability materials" button (if movements have been added after confirming the materials).

TT35602

project_stock 13.0.1.1.1
…e if there is any assigned move.

TT36812

[UPD] Update project_stock.pot

project_stock 13.0.1.1.2

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: project-13.0/project-13.0-project_stock
Translate-URL: https://translation.odoo-community.org/projects/project-13-0/project-13-0-project_stock/
TT34555

[UPD] Update project_stock.pot
… sections (project and task) from stock to stock.group_stock_user.

TT35602
…in moves to prevent merge moves from another tasks.

TT37708

[UPD] Update project_stock.pot

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: project-13.0/project-13.0-project_stock
Translate-URL: https://translation.odoo-community.org/projects/project-13-0/project-13-0-project_stock/
TT37708

project_stock 13.0.2.0.1

project_stock 13.0.2.1.0
TT37028

[UPD] Update project_stock.pot

[UPD] README.rst
Currently translated at 94.6% (53 of 56 strings)

Translation: project-14.0/project-14.0-project_stock
Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_stock/hr/
We need to apply sudo to avoid error if the user does not have access to analytical accounting.
TT38702

project_stock 14.0.1.0.1
The possibility of set a specific date in project or task has been added
so that if it is set it will be used in analytic items linked to materials.

TT38988

[UPD] Update project_stock.pot

project_stock 14.0.1.1.0

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: project-14.0/project-14.0-project_stock
Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_stock/
Currently translated at 33.3% (19 of 57 strings)

Translation: project-14.0/project-14.0-project_stock
Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_stock/it/
…ns in tasks.

TT39639

project_stock 14.0.1.1.1
@victoralmau victoralmau force-pushed the 15.0-mig-project_stock branch from 691e6c7 to 5cd377b Compare November 4, 2022 16:33
@pedrobaeza
Copy link
Member

/ocabot migration project_stock

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Nov 5, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 5, 2022
32 tasks
project_stock/models/stock_move.py Outdated Show resolved Hide resolved
project_stock/models/stock_move.py Outdated Show resolved Hide resolved
project_stock/tests/test_project_stock.py Outdated Show resolved Hide resolved
project_stock/tests/test_project_stock.py Outdated Show resolved Hide resolved
@victoralmau victoralmau force-pushed the 15.0-mig-project_stock branch 2 times, most recently from 68200a3 to e271455 Compare November 7, 2022 09:49
@victoralmau victoralmau force-pushed the 15.0-mig-project_stock branch from e271455 to b1bf079 Compare November 7, 2022 09:49
@victoralmau
Copy link
Member Author

Changes done and tests fixed.

@victoralmau victoralmau force-pushed the 15.0-mig-project_stock branch 2 times, most recently from a82c8d9 to e9db14b Compare November 8, 2022 08:08
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I detected an issue in my functional test:

  • When I try to add more than one product line to the task and save it the following error is raised:
UncaughtPromiseError > TypeError
Uncaught Promise > Cannot read properties of undefined (reading 'type')

TypeError: Cannot read properties of undefined (reading 'type')
    at compareRecords (http://localhost:15069/web/assets/debug/web.assets_backend.js:69576:45)
    at stableCompare (http://localhost:15069/web/assets/debug/web.assets_common.js:66639:25)
    at Array.sort (<anonymous>) (/web/static/src/legacy/js/views/basic/basic_model.js:5170)
    at Object.stableSort (http://localhost:15069/web/assets/debug/web.assets_common.js:66638:22) (/web/static/src/legacy/js/core/utils.js:904)
    at Class._sortList (http://localhost:15069/web/assets/debug/web.assets_backend.js:69588:19) (/web/static/src/legacy/js/core/utils.js:903)
    at http://localhost:15069/web/assets/debug/web.assets_backend.js:69269:26 (/web/static/src/legacy/js/views/basic/basic_model.js:5182)
    at async Promise.all (index 4) (/web/static/src/legacy/js/views/basic/basic_model.js:4863)
    at async Promise.all (index 0)

project_stock/README.rst Outdated Show resolved Hide resolved
project_stock/README.rst Outdated Show resolved Hide resolved
@victoralmau victoralmau force-pushed the 15.0-mig-project_stock branch from e9db14b to fb3f2ed Compare November 9, 2022 08:35
@victoralmau
Copy link
Member Author

I detected an issue in my functional test:

* When I try to add more than one product line to the task and save it the following error is raised:

Changes done and and problem solved.

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now the test went perfect 👍 Good job!

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-1020-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 2ea3e3a into OCA:15.0 Nov 9, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 230d07f. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants