-
-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] product_code_mandatory: Migration to 18.0 #1771
Open
pfranck
wants to merge
41
commits into
OCA:18.0
Choose a base branch
from
pfranck:18.0-mig-product_code_mandatory
base: 18.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [ADD] Module to set the internal reference of the product as required.
Currently translated at 100.0% (3 of 3 strings) Translation: product-attribute-12.0/product-attribute-12.0-product_code_mandatory Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_code_mandatory/pt/
Currently translated at 83.3% (5 of 6 strings) Translation: product-attribute-14.0/product-attribute-14.0-product_code_mandatory Translate-URL: https://translation.odoo-community.org/projects/product-attribute-14-0/product-attribute-14-0-product_code_mandatory/fr/
Currently translated at 83.3% (5 of 6 strings) Translation: product-attribute-14.0/product-attribute-14.0-product_code_mandatory Translate-URL: https://translation.odoo-community.org/projects/product-attribute-14-0/product-attribute-14-0-product_code_mandatory/fr_FR/
Currently translated at 100.0% (2 of 2 strings) Translation: product-attribute-15.0/product-attribute-15.0-product_code_mandatory Translate-URL: https://translation.odoo-community.org/projects/product-attribute-15-0/product-attribute-15-0-product_code_mandatory/ca/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-attribute-15.0/product-attribute-15.0-product_code_mandatory Translate-URL: https://translation.odoo-community.org/projects/product-attribute-15-0/product-attribute-15-0-product_code_mandatory/
Currently translated at 100.0% (3 of 3 strings) Translation: product-attribute-15.0/product-attribute-15.0-product_code_mandatory Translate-URL: https://translation.odoo-community.org/projects/product-attribute-15-0/product-attribute-15-0-product_code_mandatory/it/
Move setUp test class to setUpClass for better performant [ADD] product_code_mandatory: Add contributors [IMP] product_cost_security: clarify product cost edit required permissions As seen in OCA/margin-analysis#198 (review), a user needs some other group that grants them permissions for editing products, apart from this one that allows them to edit product cost. This might not seem obvious to the user, so it's better to document it. Btw, I renamed the groups to be shorter. Still easy to understand, now that groups are grouped (🥁). @moduon MT-5158 [UPD] Update product_cost_security.pot [BOT] post-merge updates Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-attribute-16.0/product-attribute-16.0-product_cost_security Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_cost_security/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-attribute-17.0/product-attribute-17.0-product_code_mandatory Translate-URL: https://translation.odoo-community.org/projects/product-attribute-17-0/product-attribute-17-0-product_code_mandatory/
Currently translated at 100.0% (3 of 3 strings) Translation: product-attribute-17.0/product-attribute-17.0-product_code_mandatory Translate-URL: https://translation.odoo-community.org/projects/product-attribute-17-0/product-attribute-17-0-product_code_mandatory/it/
luc-adhoc
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
functional review
/ocabot migration product_code_mandatory |
@pfranck Thanks for this. You should do a migration commit. Please follow : https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0#how-to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.