Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][IMP] product_set: Merge with sale_product_set_layout #1452

Merged
merged 1 commit into from
Dec 14, 2023
Merged

[16.0][IMP] product_set: Merge with sale_product_set_layout #1452

merged 1 commit into from
Dec 14, 2023

Conversation

CRogos
Copy link
Contributor

@CRogos CRogos commented Nov 18, 2023

@CRogos CRogos mentioned this pull request Nov 18, 2023
Merged
@CRogos CRogos marked this pull request as ready for review November 18, 2023 22:21
This was referenced Nov 18, 2023
Closed
Open
MohamedOsman7
MohamedOsman7 approved these changes Nov 27, 2023
View reviewed changes
Copy link

@MohamedOsman7 MohamedOsman7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional changes LGTM

pedrobaeza
pedrobaeza approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge major

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1452-by-pedrobaeza-bump-major, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit eadbe86 into OCA:16.0 Dec 14, 2023
8 of 9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7622ce1. Thanks a lot for contributing to OCA. ❤️

@CRogos CRogos mentioned this pull request Dec 15, 2023
Merged
@CRogos CRogos deleted the 16.0-mig-sale_product_set_layout branch December 15, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MohamedOsman7 MohamedOsman7 MohamedOsman7 approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CRogos @OCA-git-bot @pedrobaeza @MohamedOsman7