[10.0][IMP] partner_identification: Add field computation and inverses #419

lasley · 2017-05-17T15:51:14Z

This PR add methods to allow for computation and inverse of an ID field of a specific category type, such as in the following example:

social_security_id = fields.Char(
    string='Social Security',
    compute=lambda s: s._compute_identification(
        'social_security_id', 'SSN',
    ),
    inverse=lambda s: s._inverse_identification(
        'social_security_id', 'SSN',
    ),
)

In the above example, the first Identification found in the SSN category code for the partner will be used for computation. The inverse blocks write when there is more than one active ID for the same type and partner in order to avoid accidental mutation of an incorrect record.

This has been working in Vertical Medical core for a while now, I'd just like to move it here for more abstract usage.

* Add methods to allow for computation and inverse of an ID field of a specific category type

lasley · 2017-05-17T17:13:26Z

cc @jbeficent - this was moved from OCA/vertical-medical#174

lmignon · 2017-05-19T06:02:06Z

@lasley Thank you for this new feature. The code LGTM. It would be nice to also provide search method to be complete. Nevertheless 👍 (Code review only)

luismontalba

Functionality tested on runbot

rafaelbn · 2017-05-29T09:49:27Z

Please @lasley could you review travis errors? Thanks!

cubells

👍
LGTM

cubells · 2017-05-29T13:55:49Z

Travis error not related to module.

pedrobaeza · 2017-05-30T00:21:22Z

@lasley do you know why the branch is red?

AaronHForgeFlow

It works good, pending to figure it out what is causing travis to fail

rafaelbn · 2017-05-30T08:47:28Z

Well, @lasley it could be nice to discover why the branch is red, in any case I don't think we must block merging this PR in any case

rafaelbn · 2017-05-30T08:49:53Z

Well, one doubt, in you first commit it was no error, in the second it appears.

rafaelbn

Travis says red but there is no error in https://travis-ci.org/OCA/partner-contact/jobs/236469721 so is 👍

(cherry picked from commit eadcae2) Conflicts: partner_identification/__openerp__.py Set version to 8.0.1.0.0. Remove dependency on sales_team, as the relevant change is not in 8.0. Change emails to the new ones (cherry picked from commit 3455ae6) Update new name (cherry picked from commit 5b592d7) [FIX] try me on runbot link (cherry picked from commit bd587b6) Conflicts: partner_identification/README.rst Changed runbot to 8.0 [IMP] partner_identification: Add context override (OCA#373) Allow for context override of validations using ``id_no_validate`` (cherry picked from commit 76c2e7b) [10.0][IMP] partner_identification: Add field computation and inverses (OCA#419) * [IMP] partner_identification: Add field computation and inverses * Add methods to allow for computation and inverse of an ID field of a specific category type * [IMP] partner_identification: Add search option (cherry picked from commit 19c5fb6) [FIX] partner_identification: Infinite loop in search (OCA#436) (cherry picked from commit fa9b390) [FIX] partner-contact CI interactions (cherry picked from commit bc93e7b) [ADD][8.0] Backport of the 9.0 module. (cherry picked from commit a425403) [8.0][MIG] partner_identification backport

OCA#419) * [IMP] partner_identification: Add field computation and inverses * Add methods to allow for computation and inverse of an ID field of a specific category type * [IMP] partner_identification: Add search option

(cherry picked from commit eadcae2) Conflicts: partner_identification/__openerp__.py Set version to 8.0.1.0.0. Remove dependency on sales_team, as the relevant change is not in 8.0. Change emails to the new ones (cherry picked from commit 3455ae6) Update new name (cherry picked from commit 5b592d7) [FIX] try me on runbot link (cherry picked from commit bd587b6) Conflicts: partner_identification/README.rst Changed runbot to 8.0 [IMP] partner_identification: Add context override (OCA#373) Allow for context override of validations using ``id_no_validate`` (cherry picked from commit 76c2e7b) [10.0][IMP] partner_identification: Add field computation and inverses (OCA#419) * [IMP] partner_identification: Add field computation and inverses * Add methods to allow for computation and inverse of an ID field of a specific category type * [IMP] partner_identification: Add search option (cherry picked from commit 19c5fb6) [FIX] partner_identification: Infinite loop in search (OCA#436) (cherry picked from commit fa9b390) [FIX] partner-contact CI interactions (cherry picked from commit bc93e7b) [ADD][8.0] Backport of the 9.0 module. (cherry picked from commit a425403) [8.0][MIG] partner_identification backport

OCA#419) * [IMP] partner_identification: Add field computation and inverses * Add methods to allow for computation and inverse of an ID field of a specific category type * [IMP] partner_identification: Add search option

lasley mentioned this pull request May 17, 2017

[RFC] partner_identification: Pass-Through Fields #365

Closed

lasley force-pushed the feature/10.0/partner_identification_1.1.0 branch 6 times, most recently from e832264 to d5d6265 Compare May 17, 2017 16:44

[IMP] partner_identification: Add field computation and inverses

81c8544

* Add methods to allow for computation and inverse of an ID field of a specific category type

lasley force-pushed the feature/10.0/partner_identification_1.1.0 branch from d5d6265 to 81c8544 Compare May 17, 2017 17:12

lmignon approved these changes May 19, 2017

View reviewed changes

lasley force-pushed the feature/10.0/partner_identification_1.1.0 branch 3 times, most recently from 5cf80aa to df34e43 Compare May 22, 2017 22:13

[IMP] partner_identification: Add search option

b41812f

lasley force-pushed the feature/10.0/partner_identification_1.1.0 branch from df34e43 to b41812f Compare May 26, 2017 18:03

rafaelbn added this to the 10.0 milestone May 29, 2017

rafaelbn added the needs review label May 29, 2017

luismontalba approved these changes May 29, 2017

View reviewed changes

cubells approved these changes May 29, 2017

View reviewed changes

AaronHForgeFlow reviewed May 30, 2017

View reviewed changes

rafaelbn approved these changes May 30, 2017

View reviewed changes

rafaelbn merged commit 19c5fb6 into OCA:10.0 May 30, 2017

lasley deleted the feature/10.0/partner_identification_1.1.0 branch May 30, 2017 16:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[10.0][IMP] partner_identification: Add field computation and inverses #419

[10.0][IMP] partner_identification: Add field computation and inverses #419

lasley commented May 17, 2017 •

edited

Loading

lasley commented May 17, 2017 •

edited

Loading

lmignon commented May 19, 2017

luismontalba left a comment

rafaelbn commented May 29, 2017

cubells left a comment

cubells commented May 29, 2017

pedrobaeza commented May 30, 2017

AaronHForgeFlow left a comment

rafaelbn commented May 30, 2017

rafaelbn commented May 30, 2017

rafaelbn left a comment

[10.0][IMP] partner_identification: Add field computation and inverses #419

[10.0][IMP] partner_identification: Add field computation and inverses #419

Conversation

lasley commented May 17, 2017 • edited Loading

lasley commented May 17, 2017 • edited Loading

lmignon commented May 19, 2017

luismontalba left a comment

Choose a reason for hiding this comment

rafaelbn commented May 29, 2017

cubells left a comment

Choose a reason for hiding this comment

cubells commented May 29, 2017

pedrobaeza commented May 30, 2017

AaronHForgeFlow left a comment

Choose a reason for hiding this comment

rafaelbn commented May 30, 2017

rafaelbn commented May 30, 2017

rafaelbn left a comment

Choose a reason for hiding this comment

lasley commented May 17, 2017 •

edited

Loading

lasley commented May 17, 2017 •

edited

Loading