[18.0][MIG] partner_vat_unique: Migration to 18.0 #1906
+1,029
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently translated at 100.0% (2 of 2 strings) Translation: partner-contact-12.0/partner-contact-12.0-partner_vat_unique Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_vat_unique/es/
Currently translated at 100.0% (2 of 2 strings) Translation: partner-contact-12.0/partner-contact-12.0-partner_vat_unique Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_vat_unique/it/
Currently translated at 100.0% (2 of 2 strings) Translation: partner-contact-12.0/partner-contact-12.0-partner_vat_unique Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_vat_unique/pt/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: partner-contact-13.0/partner-contact-13.0-partner_vat_unique Translate-URL: https://translation.odoo-community.org/projects/partner-contact-13-0/partner-contact-13-0-partner_vat_unique/
Currently translated at 100.0% (4 of 4 strings) Translation: partner-contact-14.0/partner-contact-14.0-partner_vat_unique Translate-URL: https://translation.odoo-community.org/projects/partner-contact-14-0/partner-contact-14-0-partner_vat_unique/es/
Currently translated at 100.0% (4 of 4 strings) Translation: partner-contact-16.0/partner-contact-16.0-partner_vat_unique Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_vat_unique/de/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: partner-contact-16.0/partner-contact-16.0-partner_vat_unique Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_vat_unique/
Currently translated at 100.0% (4 of 4 strings) Translation: partner-contact-16.0/partner-contact-16.0-partner_vat_unique Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_vat_unique/hr/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: partner-contact-16.0/partner-contact-16.0-partner_vat_unique Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_vat_unique/
Currently translated at 100.0% (4 of 4 strings) Translation: partner-contact-16.0/partner-contact-16.0-partner_vat_unique Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_vat_unique/es/
Currently translated at 100.0% (4 of 4 strings) Translation: partner-contact-16.0/partner-contact-16.0-partner_vat_unique Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_vat_unique/pt/
Currently translated at 100.0% (4 of 4 strings) Translation: partner-contact-16.0/partner-contact-16.0-partner_vat_unique Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_vat_unique/it/
lef-adhoc
changed the title
|
/ocabot migration partner_vat_unique |
rousseldenis
requested changes
Nov 29, 2024
| @@ -24,5 +24,6 @@ def _check_vat_unique(self): | |||
| continue | |||
| if record.same_vat_partner_id: | |||
| raise ValidationError( | |||
| _("The VAT %s already exists in another partner.") % record.vat | |||
| self.env._("The VAT %s already exists in another partner.") | |||
There was a problem hiding this comment.
@lef-adhoc Please use translation function arguments instead.
self.env._("The VAT %(vat)s already exists in another partner.", vat=record.vat)
| for record in self: | ||
| if record.parent_id or not record.vat: | ||
| continue | ||
| test_condition = config["test_enable"] and not self.env.context.get( |
There was a problem hiding this comment.
This is not really good practice. Instead, a configuration parameter is better to enable the constraint.
There was a problem hiding this comment.
Thanks for the feedback! Do you have an example of how to properly implement this with a configuration parameter?
There was a problem hiding this comment.
In ResConfigSettings model:
partner_vat_unique = fields.Boolean(
config_parameter="partner_vat_unique.partner_vat_unique',
help="Check this if you want to constrain VAT number to be unique"
)
Then, here, before the loop:
if self.env["ir.config_parameter"]
.sudo()
.get_param("partner_vat_unique.partner_vat_unique', False):
There was a problem hiding this comment.
Then, remove all things about test_enable.
And adapt tests accordingly.
Then, put that in a separate commit.
There was a problem hiding this comment.
I’ve added a commit implementing the configuration parameter for the unique VAT constraint as you suggested. Could you please take a look and let me know if this approach works for you?
lef-adhoc
force-pushed
the
18.0-mig-partner_vat_unique
branch
from
19a7fff to
422297f
Compare
lef-adhoc
force-pushed
the
18.0-mig-partner_vat_unique
branch
2 times, most recently
from
1fce377 to
3dcfa24
Compare
| "test_vat" | ||
| ) | ||
| if test_condition: | ||
| if ( |
There was a problem hiding this comment.
Put it outside the loop. If deactivated, don't enter in it at all.
…constraint - Defined `partner_vat_unique` as a boolean configuration parameter. - Updated `res.partner` to validate VAT uniqueness based on this parameter. - Added a new section in ResConfigSettings for enabling/disabling the constraint. - Updated tests to include scenarios with the configuration parameter.
lef-adhoc
force-pushed
the
18.0-mig-partner_vat_unique
branch
from
3dcfa24 to
1a7c237
Compare
mav-adhoc
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.