Skip to content

Commit

Permalink
Merge PR #755 into 17.0
Browse files Browse the repository at this point in the history
Signed-off-by pedrobaeza
  • Loading branch information
OCA-git-bot committed Nov 26, 2024
2 parents 38ad4e4 + 63c34f4 commit cc2ffc2
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 26 deletions.
19 changes: 0 additions & 19 deletions account_statement_base/models/account_bank_statement.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,25 +4,6 @@
class AccountBankStatement(models.Model):
_inherit = "account.bank.statement"

# TODO: Delete if merged https://github.com/odoo/odoo/pull/182497
def _compute_date_index(self):
"""The super() method does not take into account lines that do not have
internal_index set yet, and causes sorted() to fail, we need to re-define
the method in these cases to avoid the error.
"""
_self = self
for stmt in self:
if any(not line.internal_index for line in stmt.line_ids):
_self -= stmt
sorted_lines = stmt.line_ids.filtered("internal_index").sorted(
"internal_index"
)
stmt.first_line_index = sorted_lines[:1].internal_index
stmt.date = sorted_lines.filtered(lambda line: line.state == "posted")[
-1:
].date
return super(AccountBankStatement, _self)._compute_date_index()

def action_open_statement_lines(self):
self.ensure_one()
if not self:
Expand Down
7 changes: 0 additions & 7 deletions account_statement_base/models/account_bank_statement_line.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,6 @@
class AccountBankStatementLine(models.Model):
_inherit = "account.bank.statement.line"

# TODO: Delete if merged https://github.com/odoo/odoo/pull/182497
def _compute_running_balance(self):
# We need to set value to all records because super() does not do it using sql.
for item in self:
item.running_balance = item.running_balance
return super()._compute_running_balance()

def action_open_journal_entry(self):
self.ensure_one()
if not self:
Expand Down

0 comments on commit cc2ffc2

Please sign in to comment.