Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't select transitive packages in PM UI when updating a package #6179

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

martinrrm
Copy link
Contributor

Bug

Fixes: NuGet/Home#13893

Description

Transitive packages are automatically selected when you are in the Updates tab and clicking the Update button will update the package reference for the top-level packages but also add a package reference in all the projects where the package is used as a transitive dependency, promoting them to top-level, which is not the desired behavior in most of the cases.

Promoting a package from transitive to top-level is not a very common scenario, most likely only done when fixing a vulnerability or resolving a dependency conflict.

image

PR Checklist

  • Meaningful title, helpful description and a linked NuGet/Home issue
  • Added tests I'm not adding since it's a UI change in a code path with no tests, I could try to add a unit test if team wants
  • Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.

@martinrrm martinrrm requested a review from a team as a code owner December 2, 2024 18:16
@nkolev92
Copy link
Member

nkolev92 commented Dec 3, 2024

Can you ask the vendors to add a manual test if you can't add an automated one?

@martinrrm martinrrm merged commit aef398f into dev Dec 3, 2024
23 checks passed
@martinrrm martinrrm deleted the dev-martinrrm-not-select-transitives branch December 3, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nuget Packages Manager screen for Solution automatically selects transitive dependencies
5 participants