Update README loading text #6169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donnie-msft
previously approved these changes
Nov 26, 2024
jebriede
reviewed
Nov 26, 2024
src/NuGet.Clients/NuGet.PackageManagement.UI/Xamls/PackageReadmeControl.xaml.cs
Outdated
Show resolved
Hide resolved
…kdown preview is set.
donnie-msft
previously approved these changes
Nov 27, 2024
Nigusu-Allehu
previously approved these changes
Nov 27, 2024
jebriede
reviewed
Dec 4, 2024
src/NuGet.Clients/NuGet.PackageManagement.UI/Xamls/PackageReadmeControl.xaml
Outdated
Show resolved
Hide resolved
src/NuGet.Clients/NuGet.PackageManagement.UI/Xamls/PackageReadmeControl.xaml
Outdated
Show resolved
Hide resolved
src/NuGet.Clients/NuGet.PackageManagement.UI/Xamls/PackageReadmeControl.xaml.cs
Show resolved
Hide resolved
jebriede
previously approved these changes
Dec 4, 2024
jgonz120
dismissed stale reviews from jebriede, Nigusu-Allehu, and donnie-msft
via
d8de436
jebriede
approved these changes
Dec 4, 2024
Nigusu-Allehu
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes:
Description
Update the message displayed to the user when the README is loading, per the recommendation from the UX board. Ensure screen readers announce when the README is loading.
PR Checklist
Added testsLink to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.