Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove redundant Count() in GlobalPackageFolderRepositories #6166

Conversation

SimonCropp
Copy link
Contributor

Bug

Fixes:

Description

remove redundant Count() in GlobalPackageFolderRepositories. faster to use the property. Also removes null check, since if it is null it would blow up in folders.AddRange(pathContext.FallbackPackageFolders);

PR Checklist

  • Meaningful title, helpful description and a linked NuGet/Home issue
  • Added tests
  • Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.

@SimonCropp SimonCropp requested a review from a team as a code owner November 26, 2024 10:47
@dotnet-policy-service dotnet-policy-service bot added the Community PRs created by someone not in the NuGet team label Nov 26, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Status:No recent activity PRs that have not had any recent activity and will be closed if the label is not removed label Dec 3, 2024

This PR has been automatically marked as stale because it has no activity for 7 days. It will be closed if no further activity occurs within another 90 days of this comment. If it is closed, you may reopen it anytime when you're ready again, as long as you don't delete the branch.

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Status:No recent activity PRs that have not had any recent activity and will be closed if the label is not removed label Dec 3, 2024
@jeffkl jeffkl self-assigned this Dec 3, 2024
@jeffkl jeffkl merged commit b9b70a8 into NuGet:dev Dec 4, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community PRs created by someone not in the NuGet team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants