Add RID specific packages to dotnet nuget why
#6154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffkl
previously approved these changes
Nov 19, 2024
jgonz120
previously approved these changes
Nov 20, 2024
src/NuGet.Core/NuGet.CommandLine.XPlat/Commands/Why/DependencyGraphFinder.cs
Outdated
Show resolved
Hide resolved
…GraphFinder.cs Co-authored-by: Jonatan Gonzalez <[email protected]>
nkolev92
requested changes
Nov 20, 2024
src/NuGet.Core/NuGet.CommandLine.XPlat/Commands/Why/DependencyGraphFinder.cs
Outdated
Show resolved
Hide resolved
src/NuGet.Core/NuGet.CommandLine.XPlat/Commands/Why/DependencyGraphFinder.cs
Outdated
Show resolved
Hide resolved
src/NuGet.Core/NuGet.CommandLine.XPlat/Commands/Why/DependencyGraphFinder.cs
Outdated
Show resolved
Hide resolved
test/NuGet.Core.Tests/NuGet.CommandLine.Xplat.Tests/Commands/Why/DependencyGraphFinderTests.cs
Show resolved
Hide resolved
jeffkl
approved these changes
Nov 21, 2024
nkolev92
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#13718
Description
Originally
dotnet nuget whyonly showed a path in the dependency graph, only for RIDless packages only. This PR makes sure we show RID specific packages in the tree as well. This is done by creating a tree for each RID and framework combination. Each combination will have its own tree. For example, if a user hasnet9.0framework andwin-x64RID, we will have a tree fornet 9.0 / win-x64net 9.0PR Checklist
dotnet nuget whygraphs RID specific packages Home#13944