Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for solc versions 0.8.25, 0.8.26, and 0.8.27 #5740

Merged
merged 4 commits into from
Sep 16, 2024

Conversation

schaable
Copy link
Member

This PR adds support for Solidity versions 0.8.25, 0.8.26, and 0.8.27, and updates the default/latest Solidity version to 0.8.27.

Closes #5723

@schaable schaable requested a review from a team September 11, 2024 19:57
@schaable schaable self-assigned this Sep 11, 2024
Copy link

vercel bot commented Sep 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2024 8:29am

Copy link

changeset-bot bot commented Sep 11, 2024

🦋 Changeset detected

Latest commit: 0e30f4c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
hardhat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Sep 11, 2024
@galargh
Copy link
Member

galargh commented Sep 13, 2024

@schaable I restored the option to run tests for all solc versions in CI (in #5745) and kicked off a run that has the changes introduced in this PR - https://github.com/NomicFoundation/hardhat/actions/runs/10846884277. As you can see it fails with OOMs, do you think that's something we should look into more? Other than that, it looks good to me, but wanted to check with you first.

@schaable
Copy link
Member Author

@schaable I restored the option to run tests for all solc versions in CI (in #5745) and kicked off a run that has the changes introduced in this PR - NomicFoundation/hardhat/actions/runs/10846884277. As you can see it fails with OOMs, do you think that's something we should look into more? Other than that, it looks good to me, but wanted to check with you first.

To be honest, I’m not sure. It doesn’t seem directly related to adding the solc versions, so I’m inclined to think it's not an issue caused by that, but I could be wrong. @alcuadrado @fvictorio, wdyt?

@alcuadrado
Copy link
Member

@fvictorio, what's the status of these tests now that more things are ported to Rust? Should we still run them here?

@fvictorio
Copy link
Member

@alcuadrado yes. We are working right now to complete the migration. After that (and after helping adapts solc's CI to run on EDR) we'll be able to remove the stack traces tests from the Hardhat repo.

Copy link
Member

@alcuadrado alcuadrado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appproving despite the OOM that @galargh discovered, as that's a CI workflow that we don't usually run, and will be moved to EDR soon.

@schaable schaable merged commit 74b1bfe into main Sep 16, 2024
105 checks passed
@schaable schaable deleted the support-solc-0.8.27 branch September 16, 2024 16:08
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:ready This issue is ready to be worked on
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Error: Unsupported language version '0.8.27'
4 participants