Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consume downloads instead of piping them #4075

Merged
merged 2 commits into from
Jun 27, 2023
Merged

Conversation

fvictorio
Copy link
Member

This is a workaround for an issue related to node v18.16.0 (and v18.16.1), the stream module and undici. See nodejs/undici#2173 for the details.

Fixes #3877.

This is a workaround for an issue related to node v18.16.0, the stream module and undici. See nodejs/undici#2173 for the details.
@fvictorio fvictorio requested a review from alcuadrado June 27, 2023 11:56
@changeset-bot
Copy link

changeset-bot bot commented Jun 27, 2023

🦋 Changeset detected

Latest commit: 68cf2a2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
hardhat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jun 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2023 11:59am
hardhat-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2023 11:59am

@fvictorio fvictorio merged commit 176f268 into main Jun 27, 2023
@fvictorio fvictorio deleted the compiler-download-issue branch June 27, 2023 18:16
yorhodes added a commit to hyperlane-xyz/hyperlane-monorepo that referenced this pull request Jun 27, 2023
### Description

Bumps solidity coverage and hardhat versions to (hopefully) fix CI
coverage flakiness

Also bumps node version following
NomicFoundation/hardhat#4075
@wei3erHase
Copy link

THANKS! 🥕

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:ready This issue is ready to be worked on
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

hardhat compile randomly and quietly stops before compiling contracts
3 participants