Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade polkadot-sdk #813

Merged
merged 70 commits into from
Mar 14, 2024
Merged

Upgrade polkadot-sdk #813

merged 70 commits into from
Mar 14, 2024

Conversation

simonsso
Copy link
Contributor

@simonsso simonsso commented Dec 21, 2023

Regular release checklist

  • Verify merges
  • Upgrade spec_version in runtimes/eden/src/version.rs
  • cargo build --release
  • runtime upgrade on a local testnet
  • cargo test
  • Benchmarks compiles
  • Weights update or ignored
  • try-runtime
  • Run local test-net

Known issues

simonsso and others added 4 commits December 13, 2023 15:31
* Upgrade towards 1.1.0
* WIP migrate to polkadot-sdk repo
* Cleanup
* Update CI version
* Cargo update
* Auto format
* polkadot 1.1 dependencies
* Merge updates for benchmarks
* Cargo tests
* Update weights

---------

Co-authored-by: Alex Sedighi <[email protected]>
* Upgrade to 1.2.0
  integrate PreImage Pallet
* Upgrade to 1.2.1
* Test cases remove deprecated calls
* Integrate 1.3.0
* ORML force update
* Benchmark tests
* Migration for pallet_uniques
* Remove Clippy Warnings
* Remove dead code
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: Patch coverage is 4.09771% with 1217 lines in your changes are missing coverage. Please review.

Project coverage is 63.94%. Comparing base (89f228c) to head (3f72c47).

Files Patch % Lines
runtimes/eden/src/weights/pallet_identity.rs 0.00% 115 Missing ⚠️
runtimes/eden/src/weights/pallet_collective.rs 0.00% 100 Missing ⚠️
runtimes/eden/src/weights/pallet_proxy.rs 0.00% 83 Missing ⚠️
runtimes/eden/src/lib.rs 1.31% 75 Missing ⚠️
runtimes/eden/src/weights/pallet_sponsorship.rs 0.00% 65 Missing ⚠️
runtimes/eden/src/weights/pallet_uniques.rs 0.00% 62 Missing ⚠️
runtimes/eden/src/weights/pallet_message_queue.rs 0.00% 59 Missing ⚠️
...imes/eden/src/weights/pallet_collator_selection.rs 0.00% 58 Missing ⚠️
runtimes/eden/src/weights/pallet_preimage.rs 0.00% 52 Missing ⚠️
pallets/sponsorship/src/weights.rs 7.40% 50 Missing ⚠️
... and 23 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #813      +/-   ##
==========================================
- Coverage   67.32%   63.94%   -3.39%     
==========================================
  Files          49       58       +9     
  Lines       10984    11585     +601     
==========================================
+ Hits         7395     7408      +13     
- Misses       3589     4177     +588     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simonsso simonsso mentioned this pull request Feb 19, 2024
15 tasks
@simonsso simonsso force-pushed the feature_integrate_upgrade branch from a73a45d to a9dd686 Compare February 26, 2024 04:13
node/src/command.rs Outdated Show resolved Hide resolved
@simonsso simonsso force-pushed the feature_integrate_upgrade branch from aac7ebd to 2591568 Compare March 13, 2024 07:48
The docker example uses all necessary parameters.
Is readable and runable at the same time.
@simonsso simonsso force-pushed the feature_integrate_upgrade branch from 7aa0e45 to 3f72c47 Compare March 14, 2024 06:17
Copy link
Contributor Author

@simonsso simonsso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now.

@simonsso simonsso merged commit 0e5767f into master Mar 14, 2024
8 of 10 checks passed
@simonsso simonsso deleted the feature_integrate_upgrade branch March 14, 2024 07:02
@@ -37,6 +37,8 @@ pub const MICRO_NODL: Balance = MILLI_NODL / 1_000;
pub const NANO_NODL: Balance = MICRO_NODL / 1_000;

pub const EXISTENTIAL_DEPOSIT: Balance = 100 * NANO_NODL;
pub const POLKADOT_EXISTENTIAL_DEPOSIT: Balance = 10_000_000_000;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simonsso have you used these consts somewhere?

NodleUniques: pallet_nodle_uniques = 44,
Sponsorship: pallet_sponsorship = 45,
Identity: pallet_identity::{Pallet, Call, Storage, Event<T>} = 46,
Proxy: pallet_proxy = 47,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simonsso remind me why we need to introduce pallet_proxy?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants