Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement async with x operations for discord.ext.ipcx.Client #56

Merged
merged 4 commits into from
Dec 7, 2024

Conversation

No767
Copy link
Owner

@No767 No767 commented Dec 7, 2024

Summary

This PR implements the async with x operations for discord.ext.ipcx.Client. This would make it easier and more modern in order to start up the client, and is designed to be used with FastAPI's lifespan events. This also work with other frameworks that do something similar

Types of changes

What types of changes does your code introduce to discord-ext-ipcx?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (Updates to README.md, the documentation, etc)
  • Other (if none of the other choices apply)

Checklist

Put an x in the boxes that apply

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes. (if appropriate)
  • All workflows pass with my new changes
  • I have generated news fragments for this PR. (if appropriate, format is {#PR}.type.md)
  • This PR does not address a duplicate issue or PR

@No767 No767 changed the title Implement async with x opreations for discord.ext.ipcx.Client Implement async with x operations for discord.ext.ipcx.Client Dec 7, 2024
@No767 No767 merged commit f3b2a62 into main Dec 7, 2024
8 checks passed
@No767 No767 deleted the noelle/auto-close-session branch December 7, 2024 03:36
@No767 No767 mentioned this pull request Dec 9, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant